Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2024-01 - Update SFAPI #1642

Merged
merged 19 commits into from
Jan 22, 2024
Merged

2024-01 - Update SFAPI #1642

merged 19 commits into from
Jan 22, 2024

Conversation

wizardlyhel
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@frandiox frandiox mentioned this pull request Jan 17, 2024
Merged
@michenly
Copy link
Contributor

should npm run build-docs be run on this PR? all the variables description changes will change the doc.

@wizardlyhel
Copy link
Contributor Author

should npm run build-docs be run on this PR? all the variables description changes will change the doc.

Not yet. Do it in one single go after all PRs have been merged for this release

@frandiox
Fix variant redirect for unknown querystrings v2 (#1649)
9fc1b1a 
* Use caseInsensitiveMatch and ignoreUnknownOptions params in variants

* Changesets
@wizardlyhel wizardlyhel merged commit ca1161b into main Jan 22, 2024
10 checks passed
@wizardlyhel wizardlyhel deleted the hl-2024-01-update-sfapi branch January 22, 2024 17:05
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfscott gfscott gfscott left review comments

@michenly michenly michenly left review comments

@blittle blittle blittle approved these changes

@frandiox frandiox frandiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wizardlyhel @michenly @gfscott @blittle @frandiox