2024-01 - update remix #1639
2024-01 - update remix #1639
Conversation
This comment has been minimized.
This comment has been minimized.
| // skip .DS_Store files | ||
| if (srcEntry.endsWith('.DS_Store')) continue; |
There was a problem hiding this comment.
I am not sure why this is a problem now
There was a problem hiding this comment.
Maybe you opened packages/cli/src/virtual-routes with Mac's Finder or something similar? It seems it created a .DS_Store file in your machine but we shouldn't have this generally here.
The change doesn't hurt, though.
There was a problem hiding this comment.
The change doesn't hurt .. and this is happening in CI as well
There was a problem hiding this comment.
Did someone accidentally add .DS_Store to VC?
There was a problem hiding this comment.
couldn't find it
There was a problem hiding this comment.
Edit: This is only a problem when running locally when trying to run npm run build in root folder
|
@wizardlyhel I've reverted changes to peerDependencies because we still want to be compatible with Remix 2.1 to 2.4, it's up to the user (even if we only test for 2.5 now). Otherwise we'd be forcing them to update to 2.5. Also, the Remix version in the assets package.json is automatically adjusted to the user project version, so we don't need to update it with the rest of the deps. Remix 2.5.0 has a bug in the build types: remix-run/remix#8492 |
|
thanks @frandiox - would it cause any issues if |
It's only for |
| v3_fetcherPersist: true, | ||
| v3_relativeSplatpath: true, |
There was a problem hiding this comment.
We should add a changeset that describes these changes. Probably linking off to the Remix docs: https://remix.run/docs/en/main/hooks/use-resolved-path#splat-paths and https://remix.run/docs/en/main/file-conventions/remix-config#future
There was a problem hiding this comment.
I assume v3_fetcherPersist was tested to not break our optimistic data functionality?
There was a problem hiding this comment.
it doesn't break existing optimistic data functionality
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist