Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix souremaps to be included on deployments from the CLI #1623

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

blittle
Copy link
Contributor

@blittle blittle commented Jan 9, 2024

WHY are these changes introduced?

We want to generate sourcemaps even for deployments via the CLI.

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

@jgodson jgodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not ideal that we run a build command here when there's already a dedicated build command... I guess unless we force a build before running deploy there's not much getting around that though. I wonder if deploy should support all/a subset of the build flags too?

@blittle blittle merged commit 6bc1d61 into main Jan 9, 2024
10 checks passed
@blittle blittle deleted the bl-fix-sourcemap-deployment branch January 9, 2024 22:35
This was referenced Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants