Change the default Hydrogen Session implementation to be more robust in parsing session cookies #1583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The session could include invalid content, and fail to parse. This change makes it so that if an error occurs when parsing, an empty session is created instead.
HOW to test your changes?
Start up the skeleton template. Find the
session
cookie in the chrome devtools. Replace the value with a garbage value. Load the app, make sure that it doesn't crash.Post-merge steps
Checklist