Catch development store errors during init #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graygilmore
force-pushed
the
gg-handle-dev-stores
branch
from
2946efa
to
8672e4d
Compare
graygilmore
force-pushed
the
gg-handle-dev-stores
branch
from
8672e4d
to
d139b74
Compare
frandiox
approved these changes
Aug 29, 2023
max611
reviewed
Aug 29, 2023
We're about to add another case to this so I'm cleaning it up ahead of time to make the functional diff easier to read.
Developers are hitting this error when they try to create a new Hydrogen storefront on a Development Store. This catches that error and provides some better feedback on why it failed.
graygilmore
force-pushed
the
gg-handle-dev-stores
branch
from
d139b74
to
818ea9b
Compare
Force Push Patch Notes
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When developers go through the
initflow and try to create a storefront on a Development Store we throw an unhelpful error.WHAT is this pull request doing?
This updates the code to explicitly catch that error and return possible reasons for why it failed. The API throws this error for a number of reasons so we're listing them all out instead of just mentioning Development Stores.
HOW to test your changes?
Run the
initcommand and try to connect to a shop that's on a Development Store plan.Checklist