Stop using cargo-wasi #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switched this to |
jeffcharles
approved these changes
Dec 10, 2024
andrewhassan
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Didn't 🎩 but code LGTM!
One other spot I think we should update is this Github action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given cargo-wasi is no longer maintained, we should no longer use it in our function examples.
This PR will update the build command to use the newer target,
wasm32-wasip1See: https://blog.rust-lang.org/2024/04/09/updates-to-rusts-wasi-targets.html
Handles https://github.com/Shopify/shopify-functions/issues/449
Do not merge this until we have another way of running wasm-opt, probably through the CLI directly.