improved progressive rendering #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
reviewed
Feb 8, 2022
| @@ -14,7 +14,7 @@ Check out [the Vault project](https://vault.shopify.io/projects/22845) to learn | |||
|
|
|||
| ### Adding a package to your project | |||
|
|
|||
| Add the package to your project via `yarn add @shopify/recycler-flat-list recyclerlistview@3.1.0-beta.3`, and run pod install in the `ios` directory. | |||
| Add the package to your project via `yarn add @shopify/recycler-flat-list recyclerlistview@3.1.0-beta.4`, and run pod install in the `ios` directory. | |||
There was a problem hiding this comment.
This will need to be changed here, too.
Generally, let's do search and replace when upgrading recyclerlistview to make sure we don't miss anything. We can also point to the microsite for installation instructions instead, so this information is not duplicated.
There was a problem hiding this comment.
Got it, updated all
| @@ -26,7 +26,7 @@ | |||
| "@babel/runtime": "*", | |||
| "react": "*", | |||
| "react-native": "*", | |||
| "recyclerlistview": "3.1.0-beta.3" | |||
| "recyclerlistview": "3.1.0-beta.4" | |||
There was a problem hiding this comment.
this should be updated in devDependencies, too
|
@fortmarek I've updated the PR. Can you approve this? |
fortmarek
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an improvement to reduce content on first load: Flipkart/recyclerlistview#688
Renamed renderAheadOffset to drawDistance. Issue with using renderAheadOffset (which is RLV prop) is that it overrides some of the progressive rendering behaviour.
After these changes list will only draw whatever in visible in screen area on first load.