Add Apple TV support #511
Merged
Add Apple TV support #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
naqvitalha
approved these changes
Jul 5, 2022
|
Thanks for the PR. I'd also let @ElviraBurchik take a quick look before we merge this. |
|
@douglowder can you please sign the CLA? |
|
@naqvitalha I would be happy to sign the CLA, however I did not find a link to that in CONTRIBUTING.md |
|
@douglowder Here you go: https://cla.shopify.com/ |
|
Done @naqvitalha |
ElviraBurchik
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FlashList works fine on Android TV as is. For Apple TV, the podspec needs to include tvOS as a supported platform, then everything works well.
Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)
Working demo at https://github.com/douglowder/FlashListTV
Checklist