Bump RLV and remove invariant #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naqvitalha
commented
Apr 4, 2022
| requestAnimationFrame(() => { | ||
| done(); | ||
| }); | ||
| flashList.unmount(); |
There was a problem hiding this comment.
Jest isn't doing unmount on its own. In real world async operations will stop as soon as component unmounts. This test was breaking intermittently so I fixed it.
ElviraBurchik
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading RLV to beta version. The new version of RLV has a fix to a long standing issue when if first item's layout doesn't change at all after a change in layout manager then layout of the second item can be wrong. It's an extreme edge case but I fixed it to avoid seeing it in the future.
The fix is not important for FlashList as the layout bug will not be visible due to AutoLayout. The primary purpose of the PR is to move away from alpha version. The change will not cause regression.
Also, invariant wasn't used anywhere in the package and fixture so I removed it.
Checklist