Skip to content

Test on ubuntu-24 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@ on:

jobs:
ci:
runs-on: ubuntu-latest
name: Ruby ${{ matrix.ruby }}
runs-on: ${{ matrix.os }}
name: Ruby ${{ matrix.ruby }} / ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
ruby: ["2.5", "2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
ruby: ["3.2", "3.3"]
os: ["ubuntu-24.04", "ubuntu-22.04"]
steps:
- uses: actions/checkout@v4
with:
Expand Down
10 changes: 0 additions & 10 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ PATH
GEM
remote: https://rubygems.org/
specs:
byebug (11.1.3)
coderay (1.1.3)
diff-lcs (1.5.1)
domain_name (0.5.20190701)
unf (>= 0.0.5, < 1.0.0)
Expand All @@ -17,7 +15,6 @@ GEM
http-cookie (1.0.5)
domain_name (~> 0.5)
json_pure (2.3.1)
method_source (1.1.0)
mime-types (3.5.2)
mime-types-data (~> 3.2015)
mime-types-data (3.2024.0305)
Expand All @@ -29,12 +26,6 @@ GEM
rainbow (= 2.2.2)
rest-client (~> 2.0)
thor (~> 1.2)
pry (0.13.1)
coderay (~> 1.1)
method_source (~> 1.0)
pry-byebug (3.9.0)
byebug (~> 11.0)
pry (~> 0.13.0)
rainbow (2.2.2)
rake
rake (13.2.1)
Expand Down Expand Up @@ -71,7 +62,6 @@ DEPENDENCIES
domain_name (~> 0.5.20190701)
enterprise_script_service!
package_cloud
pry-byebug (~> 3.9.0)
rake
rake-compiler (~> 0.9)
rspec (~> 3.5)
Expand Down
1 change: 0 additions & 1 deletion enterprise_script_service.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ end
spec.add_dependency("msgpack", "~> 1.0")
spec.add_development_dependency("bundler")
# Newer versions don't work with Ruby 2.5 and 2.6
spec.add_development_dependency("pry-byebug", "~> 3.9.0")
spec.add_development_dependency("rake", "~> 13.2")
spec.add_development_dependency("rake-compiler", "~> 0.9")
spec.add_development_dependency("rspec", "~> 3.5")
Expand Down
1 change: 1 addition & 0 deletions ext/enterprise_script_service/error.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#define ENTERPRISE_SCRIPT_SERVICE_ERROR_HPP

#include <exception>
#include <cstdint>
#include "data.hpp"

enum struct status_code {
Expand Down
1 change: 1 addition & 0 deletions ext/enterprise_script_service/options.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#define ENTERPRISE_SCRIPT_SERVICE_OPTIONS_HPP

#include <ctype.h>
#include <cstdint>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
Expand Down
2 changes: 1 addition & 1 deletion spec/script_service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def max_loops(instruction_quota)

error = result.errors[0]
expect(error).to be_an(EnterpriseScriptService::EngineSyntaxError)
expect(error.message).to eq("syntax_error.rb:1:3: syntax error, unexpected keyword_end")
expect(error.message).to include("syntax_error.rb:1:3: syntax error")
expect(error.filename).to eq("syntax_error.rb")
expect(error.line_number).to eq(1)
expect(error.column).to eq(3)
Expand Down
1 change: 0 additions & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
require("enterprise_script_service")
require("pry")

RSpec.configure do |config|
config.expect_with(:rspec) do |expectations|
Expand Down
Loading