Created the new CIRecordHelper behaviour and an associate rake task:
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Recording the deprecations whitelist for thousands of tests is a real pain depending on how your CI is setup. Most CI runs test in parallel in different machines, the regular `Record` Behaviour from this gem will create bunch of YAML files, but since multiple test from the same test file runs on different machines, you end up with multiple yaml files for the same test suite. You'd need a way to download all artifacts from CI and "merge" all files, it's a nightmare. This PR introduce a new behaviour that leverage a feature that most CI have which is to download the log output from the test run. The `CIRecordHelper` behaviour will output a JSON representation of your deprecations. You'll simply have to download the log output locally and finally run the associate rake task meant to parse this log file and generate proper deprecation as YAML file.
Edouard-chin
force-pushed
the
ec-ci-recording-wip
branch
from
acfb897
to
b226cb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the new
CIRecordHelperbehaviour and an associate rake task:Recording the deprecations whitelist for thousands of tests is a
real pain depending on how your CI is setup.
Most CI runs test in parallel in different machines, the regular
RecordBehaviour from this gem will create bunch of YAML files,but since multiple test from the same test file runs on different
machines, you end up with multiple yaml files for the same test
suite. You'd need a way to download all artifacts from CI and
"merge" all files, it's a nightmare.
This PR introduce a new behaviour that leverage a feature that most
CI have which is to download the log output from the test run.
The
CIRecordHelperbehaviour will output a JSON representation ofyour deprecations. You'll simply have to download the log output
locally and finally run the associate rake task meant to parse this
log file and generate proper deprecation as YAML file.