Add a way to mark a test as flaky: #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The deprecations triggered by some test is different (either they
get triggered in a different order or they don't trigger the same
amount of deprecations between multiple test runs).
By definition the test is flaky. Even if at the end the test passes,
the fact that sometime a method run and sometime it doesn't is the
sign of flakyness.
The deprecation toolkit can't deal with that.
This PR adds a way to mark a test as flaky so that the deprecations
triggered by the test will be ignored.
The syntax is like that:
```YAML
my_test:
- flaky: true
```
Edouard-chin
force-pushed
the
ec-flaky-test
branch
from
2ee0951
to
d4bb28b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to mark a test as flaky:
The deprecations triggered by some test is different (either they
get triggered in a different order or they don't trigger the same
amount of deprecations between multiple test runs).
By definition the test is flaky. Even if at the end the test passes,
the fact that sometime a method run and sometime it doesn't is the
sign of flakyness.
The deprecation toolkit can't deal with that.
This PR adds a way to mark a test as flaky so that the deprecations
triggered by the test will be ignored.
The syntax is like that: