Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cart-notification.liquid #3651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

oxsmose
Copy link

@oxsmose oxsmose commented Oct 16, 2024

Update

balise by

to improve SEO hierarchy. H2 should be before the H1 of collection and product title.

PR Summary:

I update the html balise used to show the notification message when a product is added to the card.

Why are these changes introduced?

H2 balise for notification replaced by a P balise.
Class h2 has been added to get the exact same style.

What approach did you take?

Other considerations

Decision log

# Decision Alternatives Rationale Downsides
1

Visual impact on existing themes

There will have no visual change.

Testing steps/scenarios

  • Step 1: Add a product, and I checked that message is shown as before. No change introduced.

Demo links

Checklist

Update <h2> balise by <p> to improve SEO hierarchy. H2 should be before the H1 of collection and product title.
@oxsmose
Copy link
Author

oxsmose commented Oct 16, 2024

I have signed the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant