Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use translation keys for default values in liquid files #3484

Merged
merged 4 commits into from
May 29, 2024
Merged

Use translation keys for default values in liquid files #3484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d7b635
Use translation keys for default values in liquid files
dpasiliao May 22, 2024
e09e610
Update 10 translation files
translation-platform[bot] May 23, 2024
ec9efda
Update 10 translation files
translation-platform[bot] May 27, 2024
8c6f311
Update 10 translation files
translation-platform[bot] May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
168 changes: 114 additions & 54 deletions locales/cs.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/da.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/de.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

156 changes: 108 additions & 48 deletions locales/en.default.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/es.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/fi.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/fr.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/it.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/ja.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/ko.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/nb.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/nl.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/pl.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/pt-BR.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/pt-PT.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/sv.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/th.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/tr.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/vi.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/zh-CN.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 114 additions & 54 deletions locales/zh-TW.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion sections/announcement-bar.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
</div>
</div>

{% schema %}

Check notice on line 163 in sections/announcement-bar.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/announcement-bar.liquid#L163 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.announcement-bar.name",
"max_blocks": 12,
Expand Down Expand Up @@ -243,7 +243,7 @@
{
"type": "text",
"id": "text",
"default": "Welcome to our store",
"default": "t:sections.announcement-bar.blocks.announcement.settings.text.default",
"label": "t:sections.announcement-bar.blocks.announcement.settings.text.label"
},
{
Expand Down
4 changes: 2 additions & 2 deletions sections/collage.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@
</div>
</div>

{% schema %}

Check notice on line 211 in sections/collage.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/collage.liquid#L211 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.collage.name",
"tag": "section",
Expand All @@ -220,7 +220,7 @@
{
"type": "inline_richtext",
"id": "heading",
"default": "Multimedia collage",
"default": "t:sections.collage.settings.heading.default",
"label": "t:sections.collage.settings.heading.label"
},
{
Expand Down Expand Up @@ -385,7 +385,7 @@
{
"type": "text",
"id": "description",
"default": "Describe the video",
"default": "t:sections.collage.blocks.video.settings.description.default",
"label": "t:sections.collage.blocks.video.settings.description.label",
"info": "t:sections.collage.blocks.video.settings.description.info"
}
Expand Down
4 changes: 2 additions & 2 deletions sections/collapsible-content.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
</div>
</div>

{% schema %}

Check notice on line 109 in sections/collapsible-content.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/collapsible-content.liquid#L109 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.collapsible_content.name",
"tag": "section",
Expand All @@ -124,7 +124,7 @@
"type": "inline_richtext",
"id": "heading",
"label": "t:sections.collapsible_content.settings.heading.label",
"default": "Collapsible content"
"default": "t:sections.collapsible_content.settings.heading.default"
},
{
"type": "select",
Expand Down Expand Up @@ -284,7 +284,7 @@
{
"type": "text",
"id": "heading",
"default": "Collapsible row",
"default": "t:sections.collapsible_content.blocks.collapsible_row.settings.heading.default",
"label": "t:sections.collapsible_content.blocks.collapsible_row.settings.heading.label",
"info": "t:sections.collapsible_content.blocks.collapsible_row.settings.heading.info"
},
Expand Down
2 changes: 1 addition & 1 deletion sections/collection-list.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
</div>
</div>

{% schema %}

Check notice on line 132 in sections/collection-list.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/collection-list.liquid#L132 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.collection-list.name",
"tag": "section",
Expand All @@ -142,7 +142,7 @@
{
"type": "inline_richtext",
"id": "title",
"default": "Collections",
"default": "t:sections.collection-list.settings.title.default",
"label": "t:sections.collection-list.settings.title.label"
},
{
Expand Down
4 changes: 2 additions & 2 deletions sections/contact-form.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
</div>
</div>

{% schema %}

Check notice on line 136 in sections/contact-form.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/contact-form.liquid#L136 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.contact-form.name",
"tag": "section",
Expand All @@ -145,8 +145,8 @@
{
"type": "inline_richtext",
"id": "heading",
"default": "Contact form",
"label": "Heading"
"default": "t:sections.contact-form.settings.title.default",
"label": "t:sections.contact-form.settings.title.label"
},
{
"type": "select",
Expand Down
4 changes: 2 additions & 2 deletions sections/email-signup-banner.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
</div>
</div>

{% schema %}

Check notice on line 139 in sections/email-signup-banner.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/email-signup-banner.liquid#L139 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.email-signup-banner.name",
"tag": "section",
Expand Down Expand Up @@ -309,7 +309,7 @@
{
"type": "text",
"id": "heading",
"default": "Opening soon",
"default": "t:sections.email-signup-banner.blocks.heading.settings.heading.default",
"label": "t:sections.email-signup-banner.blocks.heading.settings.heading.label"
},
{
Expand Down Expand Up @@ -342,7 +342,7 @@
{
"type": "richtext",
"id": "text",
"default": "<p>Be the first to know when we launch.</p>",
"default": "t:sections.email-signup-banner.blocks.paragraph.settings.paragraph.default",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, related to my previous comment, we should keep the <p> tags here in the liquid file, rather than the translations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is the way Core and SFR handle translations is if the string has the t:... pattern and it's not currently set up to have interpolation where the translation is surrounded by a <p> tag.

There is this fallback where we could have the translation not have HTML tags at all (source) but it does technically break convention and risks failing the richtext validation test in the Online Store Editor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, good context! Aligned to leave the <p> tags in for now, and I should have checked the original PR to see if this was raised then 😅

"label": "t:sections.email-signup-banner.blocks.paragraph.settings.paragraph.label"
},
{
Expand Down
2 changes: 1 addition & 1 deletion sections/featured-blog.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
</div>
</div>

{% schema %}

Check notice on line 189 in sections/featured-blog.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/featured-blog.liquid#L189 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.featured-blog.name",
"tag": "section",
Expand All @@ -197,7 +197,7 @@
{
"type": "inline_richtext",
"id": "heading",
"default": "Blog posts",
"default": "t:sections.featured-blog.settings.heading.default",
"label": "t:sections.featured-blog.settings.heading.label"
},
{
Expand Down
2 changes: 1 addition & 1 deletion sections/featured-collection.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
</div>
</div>

{% schema %}

Check notice on line 193 in sections/featured-collection.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/featured-collection.liquid#L193 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.featured-collection.name",
"tag": "section",
Expand All @@ -202,7 +202,7 @@
{
"type": "inline_richtext",
"id": "title",
"default": "Featured collection",
"default": "t:sections.featured-collection.settings.title.default",
"label": "t:sections.featured-collection.settings.title.label"
},
{
Expand Down
10 changes: 5 additions & 5 deletions sections/featured-product.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,11 +365,11 @@
render 'share-button', block: block, share_link: share_url
%}
{%- when 'variant_picker' -%}
{% render 'product-variant-picker',
product: product,
block: block,
product_form_id: product_form_id
%}

Check warning on line 372 in sections/featured-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/featured-product.liquid#L368-L372 

[NestedSnippet] Too many nested snippets

Check warning on line 372 in sections/featured-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/featured-product.liquid#L368-L372 

[NestedSnippet] Too many nested snippets

Check warning on line 372 in sections/featured-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/featured-product.liquid#L368-L372 

[NestedSnippet] Too many nested snippets
{%- when 'buy_buttons' -%}
{%- render 'buy-buttons',
block: block,
Expand Down Expand Up @@ -513,7 +513,7 @@
{% endif %}
</product-info>

{% schema %}

Check notice on line 516 in sections/featured-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/featured-product.liquid#L516 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.featured-product.name",
"tag": "section",
Expand All @@ -532,7 +532,7 @@
{
"type": "inline_richtext",
"id": "text",
"default": "Text block",
"default": "t:sections.featured-product.blocks.text.settings.text.default",
"label": "t:sections.featured-product.blocks.text.settings.text.label"
},
{
Expand Down Expand Up @@ -695,7 +695,7 @@
"type": "text",
"id": "share_label",
"label": "t:sections.featured-product.blocks.share.settings.text.label",
"default": "Share"
"default": "t:sections.featured-product.blocks.share.settings.text.default"
},
{
"type": "paragraph",
Expand Down Expand Up @@ -947,7 +947,7 @@
{
"type": "inline_richtext",
"id": "heading_1",
"default": "Heading",
"default": "t:sections.main-product.blocks.icon_with_text.settings.heading_1.default",
"label": "t:sections.main-product.blocks.icon_with_text.settings.heading_1.label",
"info": "t:sections.main-product.blocks.icon_with_text.settings.heading.info"
},
Expand Down Expand Up @@ -1143,7 +1143,7 @@
{
"type": "inline_richtext",
"id": "heading_2",
"default": "Heading",
"default": "t:sections.main-product.blocks.icon_with_text.settings.heading_2.default",
"label": "t:sections.main-product.blocks.icon_with_text.settings.heading_2.label",
"info": "t:sections.main-product.blocks.icon_with_text.settings.heading.info"
},
Expand Down Expand Up @@ -1339,7 +1339,7 @@
{
"type": "inline_richtext",
"id": "heading_3",
"default": "Heading",
"default": "t:sections.main-product.blocks.icon_with_text.settings.heading_3.default",
"label": "t:sections.main-product.blocks.icon_with_text.settings.heading_3.label",
"info": "t:sections.main-product.blocks.icon_with_text.settings.heading.info"
}
Expand Down
8 changes: 4 additions & 4 deletions sections/footer.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@
{
"type": "inline_richtext",
"id": "heading",
"default": "Quick links",
"default": "t:sections.footer.blocks.link_list.settings.heading.default",
"label": "t:sections.footer.blocks.link_list.settings.heading.label"
},
{
Expand Down Expand Up @@ -372,13 +372,13 @@
{
"type": "inline_richtext",
"id": "heading",
"default": "Heading",
"default": "t:sections.footer.blocks.text.settings.heading.default",
"label": "t:sections.footer.blocks.text.settings.heading.label"
},
{
"type": "richtext",
"id": "subtext",
"default": "<p>Share contact information, store details, and brand content with your customers.</p>",
"default": "t:sections.footer.blocks.text.settings.subtext.default",
"label": "t:sections.footer.blocks.text.settings.subtext.label"
}
]
Expand Down Expand Up @@ -446,7 +446,7 @@
{
"type": "inline_richtext",
"id": "newsletter_heading",
"default": "Subscribe to our emails",
"default": "t:sections.footer.settings.newsletter_heading.default",
"label": "t:sections.footer.settings.newsletter_heading.label"
},
{
Expand Down
8 changes: 4 additions & 4 deletions sections/image-banner.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
</div>
</div>

{% schema %}

Check notice on line 169 in sections/image-banner.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/image-banner.liquid#L169 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.image-banner.name",
"tag": "section",
Expand Down Expand Up @@ -370,7 +370,7 @@
{
"type": "inline_richtext",
"id": "heading",
"default": "Image banner",
"default": "t:sections.image-banner.blocks.heading.settings.heading.default",
"label": "t:sections.image-banner.blocks.heading.settings.heading.label"
},
{
Expand Down Expand Up @@ -403,7 +403,7 @@
{
"type": "inline_richtext",
"id": "text",
"default": "Give customers details about the banner image(s) or content on the template.",
"default": "t:sections.image-banner.blocks.text.settings.text.default",
"label": "t:sections.image-banner.blocks.text.settings.text.label"
},
{
Expand Down Expand Up @@ -436,7 +436,7 @@
{
"type": "text",
"id": "button_label_1",
"default": "Button label",
"default": "t:sections.image-banner.blocks.buttons.settings.button_label_1.default",
"label": "t:sections.image-banner.blocks.buttons.settings.button_label_1.label",
"info": "t:sections.image-banner.blocks.buttons.settings.button_label_1.info"
},
Expand All @@ -454,7 +454,7 @@
{
"type": "text",
"id": "button_label_2",
"default": "Button label",
"default": "t:sections.image-banner.blocks.buttons.settings.button_label_2.default",
"label": "t:sections.image-banner.blocks.buttons.settings.button_label_2.label",
"info": "t:sections.image-banner.blocks.buttons.settings.button_label_2.info"
},
Expand Down
8 changes: 4 additions & 4 deletions sections/image-with-text.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
</div>
</div>

{% schema %}

Check notice on line 110 in sections/image-with-text.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/image-with-text.liquid#L110 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.image-with-text.name",
"class": "section",
Expand Down Expand Up @@ -332,7 +332,7 @@
{
"type": "inline_richtext",
"id": "heading",
"default": "Image with text",
"default": "t:sections.image-with-text.blocks.heading.settings.heading.default",
"label": "t:sections.image-with-text.blocks.heading.settings.heading.label"
},
{
Expand Down Expand Up @@ -365,7 +365,7 @@
{
"type": "text",
"id": "caption",
"default": "Add a tagline",
"default": "t:sections.image-with-text.blocks.caption.settings.text.default",
"label": "t:sections.image-with-text.blocks.caption.settings.text.label"
},
{
Expand Down Expand Up @@ -414,7 +414,7 @@
{
"type": "richtext",
"id": "text",
"default": "<p>Pair text with an image to focus on your chosen product, collection, or blog post. Add details on availability, style, or even provide a review.</p>",
"default": "t:sections.image-with-text.blocks.text.settings.text.default",
"label": "t:sections.image-with-text.blocks.text.settings.text.label"
},
{
Expand Down Expand Up @@ -443,7 +443,7 @@
{
"type": "text",
"id": "button_label",
"default": "Button label",
"default": "t:sections.image-with-text.blocks.button.settings.button_label.default",
"label": "t:sections.image-with-text.blocks.button.settings.button_label.label",
"info": "t:sections.image-with-text.blocks.button.settings.button_label.info"
},
Expand Down
2 changes: 1 addition & 1 deletion sections/main-article.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@
"type": "text",
"id": "share_label",
"label": "t:sections.main-article.blocks.share.settings.text.label",
"default": "Share"
"default": "t:sections.main-article.blocks.share.settings.text.default"
},
{
"type": "paragraph",
Expand Down
2 changes: 1 addition & 1 deletion sections/main-list-collections.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"type": "inline_richtext",
"id": "title",
"label": "t:sections.main-list-collections.settings.title.label",
"default": "Collections"
"default": "t:sections.main-list-collections.settings.title.default"
},
{
"type": "select",
Expand Down
16 changes: 8 additions & 8 deletions sections/main-product.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@
%}

{%- when 'variant_picker' -%}
{% render 'product-variant-picker', product: product, block: block, product_form_id: product_form_id %}

Check warning on line 462 in sections/main-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/main-product.liquid#L462 

[NestedSnippet] Too many nested snippets

Check warning on line 462 in sections/main-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/main-product.liquid#L462 

[NestedSnippet] Too many nested snippets

Check warning on line 462 in sections/main-product.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/main-product.liquid#L462 

[NestedSnippet] Too many nested snippets
{%- when 'buy_buttons' -%}
{%- render 'buy-buttons',
block: block,
Expand Down Expand Up @@ -771,7 +771,7 @@
{
"type": "inline_richtext",
"id": "text",
"default": "Text block",
"default": "t:sections.main-product.blocks.text.settings.text.default",
"label": "t:sections.main-product.blocks.text.settings.text.label"
},
{
Expand Down Expand Up @@ -960,7 +960,7 @@
"type": "text",
"id": "share_label",
"label": "t:sections.main-product.blocks.share.settings.text.label",
"default": "Share"
"default": "t:sections.main-product.blocks.share.settings.text.default"
},
{
"type": "paragraph",
Expand Down Expand Up @@ -991,7 +991,7 @@
{
"type": "text",
"id": "heading",
"default": "Collapsible row",
"default": "t:sections.main-product.blocks.collapsible_tab.settings.heading.default",
"info": "t:sections.main-product.blocks.collapsible_tab.settings.heading.info",
"label": "t:sections.main-product.blocks.collapsible_tab.settings.heading.label"
},
Expand Down Expand Up @@ -1198,7 +1198,7 @@
{
"type": "text",
"id": "text",
"default": "Pop-up link text",
"default": "t:sections.main-product.blocks.popup.settings.link_label.default",
"label": "t:sections.main-product.blocks.popup.settings.link_label.label"
},
{
Expand Down Expand Up @@ -1231,7 +1231,7 @@
{
"type": "text",
"id": "block_heading",
"default": "Pairs well with",
"default": "t:sections.main-product.blocks.complementary_products.settings.heading.default",
"label": "t:sections.main-product.blocks.complementary_products.settings.heading.label"
},
{
Expand Down Expand Up @@ -1708,7 +1708,7 @@
{
"type": "inline_richtext",
"id": "heading_1",
"default": "Heading",
"default": "t:sections.main-product.blocks.icon_with_text.settings.heading_1.default",
"label": "t:sections.main-product.blocks.icon_with_text.settings.heading_1.label",
"info": "t:sections.main-product.blocks.icon_with_text.settings.heading.info"
},
Expand Down Expand Up @@ -1904,7 +1904,7 @@
{
"type": "inline_richtext",
"id": "heading_2",
"default": "Heading",
"default": "t:sections.main-product.blocks.icon_with_text.settings.heading_2.default",
"label": "t:sections.main-product.blocks.icon_with_text.settings.heading_2.label",
"info": "t:sections.main-product.blocks.icon_with_text.settings.heading.info"
},
Expand Down Expand Up @@ -2100,7 +2100,7 @@
{
"type": "inline_richtext",
"id": "heading_3",
"default": "Heading",
"default": "t:sections.main-product.blocks.icon_with_text.settings.heading_3.default",
"label": "t:sections.main-product.blocks.icon_with_text.settings.heading_3.label",
"info": "t:sections.main-product.blocks.icon_with_text.settings.heading.info"
}
Expand Down
8 changes: 4 additions & 4 deletions sections/multicolumn.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@
</div>
</div>

{% schema %}

Check notice on line 191 in sections/multicolumn.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/multicolumn.liquid#L191 

[SchemaJsonFormat] JSON formatting could be improved
{
"name": "t:sections.multicolumn.name",
"class": "section",
Expand All @@ -200,7 +200,7 @@
{
"type": "inline_richtext",
"id": "title",
"default": "Multicolumn",
"default": "t:sections.multicolumn.settings.title.default",
"label": "t:sections.multicolumn.settings.title.label"
},
{
Expand Down Expand Up @@ -311,7 +311,7 @@
{
"type": "text",
"id": "button_label",
"default": "Button label",
"default": "t:sections.multicolumn.settings.button_label.default",
"label": "t:sections.multicolumn.settings.button_label.label"
},
{
Expand Down Expand Up @@ -389,13 +389,13 @@
{
"type": "inline_richtext",
"id": "title",
"default": "Column",
"default": "t:sections.multicolumn.blocks.column.settings.title.default",
"label": "t:sections.multicolumn.blocks.column.settings.title.label"
},
{
"type": "richtext",
"id": "text",
"default": "<p>Pair text with an image to focus on your chosen product, collection, or blog post. Add details on availability, style, or even provide a review.</p>",
"default": "t:sections.multicolumn.blocks.column.settings.text.default",
"label": "t:sections.multicolumn.blocks.column.settings.text.label"
},
{
Expand Down
Loading
Loading