Conversation
Bumps the oclif group with 1 update in the / directory: [oclif](https://github.com/oclif/oclif). Updates `oclif` from 4.22.73 to 4.22.81 - [Release notes](https://github.com/oclif/oclif/releases) - [Changelog](https://github.com/oclif/oclif/blob/main/CHANGELOG.md) - [Commits](oclif/oclif@4.22.73...4.22.81) --- updated-dependencies: - dependency-name: oclif dependency-version: 4.22.81 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: oclif ... Signed-off-by: dependabot[bot] <support@github.com>
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Coverage report
Test suite run success3768 tests passing in 1448 suites. Report generated by 🧪jest coverage report action from 0fe16e5 |
![binks-code-reviewer[bot]](https://avatars.githubusercontent.com/in/2788732?s=60&v=4){kind=small}
| buggyFunction(otherVersion: string): boolean { | ||
| if (otherVersion === null) { | ||
| return false | ||
| } |
There was a problem hiding this comment.
Impossible null-check on string parameter in buggyFunction
buggyFunction declares otherVersion: string, but then checks if (otherVersion === null). In TypeScript, string cannot be null (unless strictNullChecks is off or the caller uses any). This is dead code or indicates the parameter type is wrong. With strictNullChecks/lint rules, this can be flagged and break CI; without it, the check still doesn’t protect against undefined.
| return true | ||
| } | ||
|
|
||
| return CLI_KIT_VERSION > otherVersion |
There was a problem hiding this comment.
Version comparison uses lexicographic string > instead of semver
return CLI_KIT_VERSION > otherVersion compares version strings lexicographically, not semver. Example: "10.0.0" > "9.9.9" is false lexicographically because '1' < '9' at the first character. This will produce incorrect results for many versions if used for gating behavior.
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - 1 findings 📋 History✅ 2 findings → ✅ 2 findings → ✅ No issues → ✅ 1 findings → ✅ No issues → ✅ 1 findings → ✅ No issues → ✅ 1 findings |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/testing/ui.d.ts@@ -45,7 +45,6 @@ export declare function waitForInputsToBeReady(): Promise<unknown>;
* Wait for the last frame to change to anything.
*/
export declare function waitForChange(func: () => void, getChangingValue: () => string | number | undefined): Promise<void>;
-export declare function waitFor(func: () => void, condition: () => boolean): Promise<void>;
/**
* Wait for the last frame to contain specific text.
*/
|
| "**/{commands,hooks}/**/*.ts!", | ||
| "**/public/**/*.{ts,tsx}!" | ||
| "**/public/**/*.{ts,tsx}!", | ||
| "bin/**/*.ts" |
There was a problem hiding this comment.
Unrelated changes to fix knip
gonzaloriestra
force-pushed
the
add-p-alias-for-pnpm
branch
from
32bc107 to
bcdda1e
Compare
gonzaloriestra
force-pushed
the
add-p-alias-for-pnpm
branch
from
bcdda1e to
69893fb
Compare
gonzaloriestra
force-pushed
the
add-p-alias-for-pnpm
branch
from
e148ed2 to
3d3a17e
Compare
…50534c5fd Bump oclif from 4.22.73 to 4.22.81 in the oclif group across 1 directory
This reverts commit b60b8c5.
…into add-p-alias-for-pnpm
2 participants
WHY are these changes introduced?
In #6820 the
palias forpnpmcommand was removedWHAT is this pull request doing?
Adds the alias back, as some of us are clumsy and were used to it.
It's added as a bin script as part of
dev up, and it only works in this repo.How to test your changes?
dev upp lintMeasuring impact
How do we know this change was effective? Please choose one:
Checklist