Refactor extension build process to use modular build steps#6867
Refactor extension build process to use modular build steps#6867alfonso-noriega wants to merge 1 commit into01-build-steps-infrastructurefrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
64d581f to
c4c3353
Compare
1c5c718 to
3ac919f
Compare
c4c3353 to
d2a2b21
Compare
2b6f7ba to
68c2a9f
Compare
d2a2b21 to
3837d71
Compare
8096aa6 to
f6ae0a0
Compare
794d3e0 to
75deab1
Compare
f6ae0a0 to
1b503e0
Compare
75deab1 to
feab6d2
Compare
1b503e0 to
01cfc8b
Compare
feab6d2 to
27b8cfc
Compare
01cfc8b to
048e70a
Compare
27b8cfc to
34005f5
Compare
048e70a to
c25acc0
Compare
4dd6917 to
56f0d4a
Compare
Coverage report
Test suite run success3851 tests passing in 1492 suites. Report generated by 🧪jest coverage report action from 61f4d35 |
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
34005f5 to
c2808f7
Compare
cfe3768 to
d802f80
Compare
445a4c4 to
f14e0e0
Compare
d802f80 to
85cabf0
Compare
f14e0e0 to
ef0c29e
Compare
85cabf0 to
61f4d35
Compare
| identifier: HostedAppHomeSpecIdentifier, | ||
| buildConfig: {mode: 'hosted_app_home'} as const, | ||
| buildConfig: {mode: 'none'} as const, | ||
| schema: HostedAppHomeSchema, |
There was a problem hiding this comment.
Hosted app home build is effectively disabled (behavior change)
The PR changes hosted_app_home from buildConfig: {mode: 'hosted_app_home'} to {mode: 'none'}. Previously, ExtensionInstance.build() had a hosted_app_home branch that called copyStaticAssets(). After this refactor, mode: 'none' produces steps = [], so no build-time actions happen for hosted app home extensions.
Evidence (new behavior):
ExtensionInstance.build()now does:const steps = buildConfig.mode === 'none' ? [] : buildConfig.stepsand runs only those steps.HostedAppHomespec now setsmode: 'none', so nothing runs.
Impact: Hosted app home extensions can ship without static assets being copied into the build output. End users (merchants) could see missing UI/resources; deployments may succeed but produce broken runtime behavior. This affects all users of that extension type.
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - 1 findings 📋 History✅ 1 findings |

WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist