Skip to content

Refactor extension build process to use modular build steps#6867

Open
alfonso-noriega wants to merge 1 commit into01-build-steps-infrastructurefrom
02-wire-build-config-into-extension-specs
Open

Refactor extension build process to use modular build steps#6867
alfonso-noriega wants to merge 1 commit into01-build-steps-infrastructurefrom
02-wire-build-config-into-extension-specs

Conversation

@alfonso-noriega
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

alfonso-noriega commented Feb 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alfonso-noriega alfonso-noriega changed the title Abstract build steps to externalize the build configuration Refactor extension build process to use modular build steps Feb 19, 2026
@alfonso-noriega alfonso-noriega force-pushed the 01-build-steps-infrastructure branch from 64d581f to c4c3353 Compare February 19, 2026 13:05
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from 1c5c718 to 3ac919f Compare February 19, 2026 13:05
@alfonso-noriega alfonso-noriega force-pushed the 01-build-steps-infrastructure branch from c4c3353 to d2a2b21 Compare February 19, 2026 13:05
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch 2 times, most recently from 2b6f7ba to 68c2a9f Compare February 19, 2026 13:20
@alfonso-noriega alfonso-noriega force-pushed the 01-build-steps-infrastructure branch from d2a2b21 to 3837d71 Compare February 19, 2026 13:27
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch 2 times, most recently from 8096aa6 to f6ae0a0 Compare February 19, 2026 13:36
@alfonso-noriega alfonso-noriega force-pushed the 01-build-steps-infrastructure branch 2 times, most recently from 794d3e0 to 75deab1 Compare February 19, 2026 13:53
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from f6ae0a0 to 1b503e0 Compare February 19, 2026 13:53
@alfonso-noriega alfonso-noriega force-pushed the 01-build-steps-infrastructure branch from 75deab1 to feab6d2 Compare February 19, 2026 14:20
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from 1b503e0 to 01cfc8b Compare February 19, 2026 14:20
@alfonso-noriega alfonso-noriega force-pushed the 01-build-steps-infrastructure branch from feab6d2 to 27b8cfc Compare February 19, 2026 14:33
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from 01cfc8b to 048e70a Compare February 19, 2026 14:33
@alfonso-noriega alfonso-noriega force-pushed the 01-build-steps-infrastructure branch from 27b8cfc to 34005f5 Compare February 19, 2026 15:31
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from 048e70a to c25acc0 Compare February 19, 2026 15:31
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch 5 times, most recently from 4dd6917 to 56f0d4a Compare February 20, 2026 12:51
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.94% 14634/18539
🟡 Branches 73.19% 7273/9937
🟡 Functions 79.16% 3714/4692
🟡 Lines 79.28% 13837/17453

Test suite run success

3851 tests passing in 1492 suites.

Report generated by 🧪jest coverage report action from 61f4d35

@alfonso-noriega alfonso-noriega marked this pull request as ready for review February 20, 2026 13:10
@alfonso-noriega alfonso-noriega requested a review from a team as a code owner February 20, 2026 13:10
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@alfonso-noriega alfonso-noriega force-pushed the 01-build-steps-infrastructure branch from 34005f5 to c2808f7 Compare February 20, 2026 15:00
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch 2 times, most recently from cfe3768 to d802f80 Compare February 24, 2026 12:43
@alfonso-noriega alfonso-noriega force-pushed the 01-build-steps-infrastructure branch 2 times, most recently from 445a4c4 to f14e0e0 Compare February 25, 2026 16:39
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from d802f80 to 85cabf0 Compare February 25, 2026 16:39
@alfonso-noriega alfonso-noriega force-pushed the 01-build-steps-infrastructure branch from f14e0e0 to ef0c29e Compare February 27, 2026 11:33
@alfonso-noriega alfonso-noriega force-pushed the 02-wire-build-config-into-extension-specs branch from 85cabf0 to 61f4d35 Compare February 27, 2026 11:33
identifier: HostedAppHomeSpecIdentifier,
buildConfig: {mode: 'hosted_app_home'} as const,
buildConfig: {mode: 'none'} as const,
schema: HostedAppHomeSchema,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hosted app home build is effectively disabled (behavior change)

The PR changes hosted_app_home from buildConfig: {mode: 'hosted_app_home'} to {mode: 'none'}. Previously, ExtensionInstance.build() had a hosted_app_home branch that called copyStaticAssets(). After this refactor, mode: 'none' produces steps = [], so no build-time actions happen for hosted app home extensions.

Evidence (new behavior):

  • ExtensionInstance.build() now does: const steps = buildConfig.mode === 'none' ? [] : buildConfig.steps and runs only those steps.
  • HostedAppHome spec now sets mode: 'none', so nothing runs.

Impact: Hosted app home extensions can ship without static assets being copied into the build output. End users (merchants) could see missing UI/resources; deployments may succeed but produce broken runtime behavior. This affects all users of that extension type.

@binks-code-reviewer
Copy link

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

Complete - 1 findings

📋 History

✅ 1 findings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant