Skip to content

Conversation

gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Oct 3, 2025

WHY are these changes introduced?

When a session is refreshed and something changes (like a new scope/app), the stored alias is replaced by the user ID

WHAT is this pull request doing?

Preserves the alias stored after login when refreshing the session

Before After
before after

How to test your changes?

  • npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251003131338
  • shopify auth login
  • shopify theme list
  • shopify auth login

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@gonzaloriestra
Copy link
Contributor Author

/snapit

Copy link
Contributor

github-actions bot commented Oct 3, 2025

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251003131338

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor

github-actions bot commented Oct 3, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.97% (+0.04% 🔼)
13311/16856
🟡 Branches
72.64% (+0.03% 🔼)
6498/8945
🟡 Functions
79.18% (+0.05% 🔼)
3441/4346
🟡 Lines
79.32% (+0.03% 🔼)
12573/15850
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
92% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

3229 tests passing in 1336 suites.

Report generated by 🧪jest coverage report action from 7fad402

@gonzaloriestra gonzaloriestra marked this pull request as ready for review October 3, 2025 13:28
@gonzaloriestra gonzaloriestra requested review from a team as code owners October 3, 2025 13:28
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Oct 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants