Specific methods for patch app configuration file scenarios #5641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
Coverage report
Test suite run success2224 tests passing in 968 suites. Report generated by 🧪jest coverage report action from 1407766 |
shauns
force-pushed
the
shauns/04-08-specific_methods_for_patch_app_configuration_file_scenarios
branch
from
fe1f0b4 to
767880c
Compare
This was referenced Apr 22, 2025
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
shauns
force-pushed
the
shauns/04-08-specific_methods_for_patch_app_configuration_file_scenarios
branch
2 times, most recently
from
953e0ef to
4209305
Compare
shauns
force-pushed
the
shauns/04-08-specific_methods_for_patch_app_configuration_file_scenarios
branch
from
4209305 to
1407766
Compare
shauns
changed the base branch from
graphite-base/5641
to
shauns/04-23-remember_randomly_selected_ports_and_don_t_reuse_them
Base automatically changed from
shauns/04-23-remember_randomly_selected_ports_and_don_t_reuse_them
to
main
April 23, 2025 14:55
isaacroldan
reviewed
Apr 23, 2025
Comment on lines
+115
to
+119
| await setManyAppConfigValues( | ||
| app.configuration.path, | ||
| [{keyPath: 'build.dev_store_url', value: store.shopDomain}], | ||
| app.configSchema, | ||
| ) |
isaacroldan
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The current implementation of
patchAppConfigurationFileis too broad, and we'll need something more specific if we want to switch out for a format preserving patcher.WHAT is this pull request doing?
This PR introduces three new, more intuitive functions for modifying app configuration:
setAppConfigValue- Sets a single value in the app configuration using a dotted path notationunsetAppConfigValue- Removes a value from the app configurationsetManyAppConfigValues- Sets multiple values at once in the app configurationThe original
patchAppConfigurationFilefunction is now marked as internal, and all existing usages have been updated to use the new functions. This provides a more declarative API for modifying configuration values.How to test your changes?
devcommand that updates URLs)Measuring impact
How do we know this change was effective? Please choose one:
Checklist