Skip to content

Conversation

@bostonaholic
Copy link
Contributor

@bostonaholic bostonaholic commented Apr 7, 2025

Fixes https://github.com/Shopify/deploys/issues/1478

  • c476c9b: Fix the bug, with hard-coded tests
  • 25d1ee4: Improve tests to be more dynamic and mitigate a bug like this in the future

This was discovered in conveyor when attempting to print the hourglass glyph with {{H}} and the orange color was not available to the formatter.

/opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:136:in `rescue in block in apply_format': invalid format specifier: orange (CLI::ui::Formatter::FormatError)
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:133:in `block in apply_format'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:130:in `each'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:130:in `each_with_object'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:130:in `apply_format'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:109:in `block in format'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:107:in `each'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:107:in `each_with_object'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:107:in `format'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui.rb:176:in `fmt'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/error_handler.rb:166:in `stderr_puts'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/error_handler.rb:129:in `rescue in triage_all_exceptions'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/error_handler.rb:96:in `triage_all_exceptions'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/error_handler.rb:64:in `call'
	from /opt/dev-dist/revisions/6814a86/bin/conveyor:78:in `<main>'
/opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:134:in `fetch': key not found: "orange" (KeyError)
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:134:in `block in apply_format'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:130:in `each'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:130:in `each_with_object'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:130:in `apply_format'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:109:in `block in format'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:107:in `each'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:107:in `each_with_object'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/formatter.rb:107:in `format'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui.rb:176:in `fmt'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/error_handler.rb:166:in `stderr_puts'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/error_handler.rb:129:in `rescue in triage_all_exceptions'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/error_handler.rb:96:in `triage_all_exceptions'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/error_handler.rb:64:in `call'
	from /opt/dev-dist/revisions/6814a86/bin/conveyor:78:in `<main>'
/opt/dev-dist/revisions/6814a86/lib/conveyor/commands/deploy_release.rb:245:in `check_required_branch_statuses': Missing or failing required status checks: (CLI::kit::Abort)
- {{H}} buildkite/world-shopify-post-merge-testing (pending)
- {{H}} buildkite/world-shopify-checks (pending)
- {{H}} buildkite/world-shopify-production-builder (pending)
You can follow up on the status checks here:
https://github.com/shop/world/commit/ad95c4478396ae44b95afabf9308c7aaae63cac4
	from /opt/dev-dist/revisions/6814a86/lib/conveyor/commands/deploy_release.rb:45:in `call'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/base_command.rb:24:in `call'
	from /opt/dev-dist/revisions/6814a86/lib/dev/command.rb:22:in `call'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/executor.rb:21:in `block (2 levels) in call'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/executor.rb:46:in `block (2 levels) in with_logging'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui/stdout_router.rb:341:in `with_id'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/executor.rb:45:in `block in with_logging'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-ui/lib/cli/ui.rb:315:in `log_output_to'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/executor.rb:44:in `with_logging'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/executor.rb:20:in `block in call'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/executor.rb:75:in `twrap'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/executor.rb:54:in `block in with_traps'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/executor.rb:75:in `twrap'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/executor.rb:53:in `with_traps'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/executor.rb:19:in `call'
	from /opt/dev-dist/revisions/6814a86/lib/dev/core_entry_point.rb:27:in `block in exec'
	from /opt/dev-dist/revisions/6814a86/lib/dev/monorail/log.rb:201:in `event'
	from /opt/dev-dist/revisions/6814a86/lib/dev/monorail/log.rb:56:in `invocation'
	from /opt/dev-dist/revisions/6814a86/lib/dev/core_entry_point.rb:26:in `exec'
	from /opt/dev-dist/revisions/6814a86/lib/conveyor/entry_point.rb:18:in `call'
	from /opt/dev-dist/revisions/6814a86/bin/conveyor:78:in `block in <main>'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/error_handler.rb:98:in `triage_all_exceptions'
	from /opt/dev-dist/revisions/6814a86/vendor/deps/cli-kit/lib/cli/kit/error_handler.rb:64:in `call'
	from /opt/dev-dist/revisions/6814a86/bin/conveyor:78:in `<main>'

@bostonaholic bostonaholic force-pushed the bostonaholic/fix-colors branch 2 times, most recently from 0c7e87b to d37c0b2 Compare April 7, 2025 18:02
@bostonaholic bostonaholic force-pushed the bostonaholic/fix-colors branch 3 times, most recently from 00ca4b7 to 85223e6 Compare April 7, 2025 20:31
@bostonaholic bostonaholic force-pushed the bostonaholic/fix-colors branch from 85223e6 to 2c63139 Compare April 7, 2025 20:36
@bostonaholic bostonaholic marked this pull request as ready for review April 7, 2025 20:44
@bostonaholic bostonaholic requested a review from a team as a code owner April 7, 2025 20:44
@bostonaholic bostonaholic merged commit 717db29 into main Apr 7, 2025
15 checks passed
@bostonaholic bostonaholic deleted the bostonaholic/fix-colors branch April 7, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants