Skip to content

Conversation

@fedorov-xyz
Copy link
Contributor

No description provided.

@fedorov-xyz
Copy link
Contributor Author

@ShogunPanda hey! Could you please review?

Copy link
Owner

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Please remove the changes in .gitignore, rest LGTM.

@fedorov-xyz
Copy link
Contributor Author

Sure, I can do that. But what's the reason? When I install dependecies locally, both node_modules and lock file are highlighted as untracked files

image

@fedorov-xyz
Copy link
Contributor Author

Done. Also fixed failed pipeline

@ShogunPanda
Copy link
Owner

Sure, I can do that. But what's the reason? When I install dependecies locally, both node_modules and lock file are highlighted as untracked files

image

I have it in my global .gitignore_global.

@fedorov-xyz
Copy link
Contributor Author

Yeah, makes sense. In general it is good practice to locally host ignores, since third-party contributors may also work with the repository. Also, the repository should have a lock file with package versions, so that all contributors and CI have consistent behavior. What do you think?

@ShogunPanda
Copy link
Owner

I don't like to submit lockfile as they add a lot of problems when rebasing branches. I rely on semver adoption from packages maintainers.

@ShogunPanda ShogunPanda merged commit 30b5b6a into ShogunPanda:main Jul 17, 2024
@fedorov-xyz fedorov-xyz deleted the feat/operation-id branch July 17, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants