Skip to content

Prefer millis over delay #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prefer millis over delay #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions src/arduino.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,21 @@ const saveFile = (filename: string, data: string) => {
const convertMelody = (notes: Note[]) => {
const midiNotesFreq = new Map<string, number>();

let code = `
void playMidi(int pin, const int notes[][3], size_t len){`;
let code = `void (*midiCtrl)(int pin, const int notes[][3], size_t len)

unsigned long currentMillis, startMillis;
int i;

void stopMidi(int pin, const int notes[][3], size_t len) {
(void) len;
if(currentMillis - startMillis >= notes[i][1]) {
noTone(pin);
startMillis = currentMillis;
midiCtrl = &playMidi;
}
}

void playMidi(int pin, const int notes[][3], size_t len) {`;

let notesCArr = `const int midi1[${notes.length}][3] = {\n`;
notes.forEach((note, idx) => {
Expand All @@ -40,11 +53,12 @@ void playMidi(int pin, const int notes[][3], size_t len){`;
notesCArr += "};";

code += `
for (int i = 0; i < len; i++) {
if(currentMillis - startMillis >= notes[i][2]) {
tone(pin, notes[i][0]);
delay(notes[i][1]);
noTone(pin);
delay(notes[i][2]);
startMillis = currentMillis;
if(++i >= len)
i = 0;
midiCtrl = &stopMidi;
}
`;

Expand All @@ -60,12 +74,15 @@ void playMidi(int pin, const int notes[][3], size_t len){`;
// main.ino or main.cpp
void setup() {
// put your setup code here, to run once:
// play midi by passing pin no., midi, midi len
playMidi(11, midi1, ARRAY_LEN(midi1));
startMillis = millis();
midiCtrl = &playMidi;
}

void loop() {
// put your main code here, to run repeatedly:
currentMillis = millis();
// play/stop midi by passing pin no., midi, midi len
midiCtrl(11, midi1, ARRAY_LEN(midi1));
}
`;

Expand Down