Add Yi Handler #543
Merged
Add Yi Handler #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantasist
commented
Jul 24, 2024
HuanzhiMao
requested changes
Jul 25, 2024
There was a problem hiding this comment.
Hey @fantasist,
Thank you for the PR.
In the decode_ast function, these lines should be removed. This will result in double-casting issue, and introduce false positives in evaluation score. For a detailed explanation, please check out #516. We addressed this issue for all model handlers there.
The rest of the PR looks great. Excited to see the yi-large-fc model on the leaderboard!
ShishirPatil
approved these changes
Jul 25, 2024
Done! |
ShishirPatil
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Thanks for the PR @fantasist and the reviews @luojy95! Appreciate your contributions to BFCL and the open-source community!
ShishirPatil
pushed a commit
that referenced
this pull request
Jul 28, 2024
aw632
pushed a commit
to vinaybagade/gorilla
that referenced
this pull request
Aug 22, 2024
Yi series models are authored by 01.ai. `yi-large` is known to be one of the SOTA LLMs. This PR adds a model handler for evaluating the public available endpoint of `yi-large-fc`, which is the version of `yi-large` model specialized in function calling capabilities. --------- Co-authored-by: Yunfan Zhong <alanwake@in.ai> Co-authored-by: Hector Lopez <hectorlopeze@in.ai> Co-authored-by: Huanzhi Mao <huanzhimao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yi series models are authored by 01.ai.
yi-largeis known to be one of the SOTA LLMs. This PR adds a model handler for evaluating the public available endpoint ofyi-large-fc, which is the version ofyi-largemodel specialized in function calling capabilities.