Colored logging configuration + displaying progress in logs #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricvidal
force-pushed
the
logging-conf
branch
2 times, most recently
from
a7ab3b3
to
9848464
Compare
- Colored logging - YAML config - Config file location set using LOGGING_CONFIG env var, defaults to logging.yaml
- Added mdc dependency Fixed progress calculation
cedricvidal
force-pushed
the
logging-conf
branch
from
9848464
to
6fafc08
Compare
ShishirPatil
approved these changes
Apr 26, 2024
devanshamin
pushed a commit
to devanshamin/gorilla
that referenced
this pull request
Jul 9, 2024
…atil#384) **Logging config** - Colored logging using `coloredlogs` package - Logging configuration loaded from YAML config file, by default `logging.yaml` - Logging configuration YAML file location overridable with `LOGGING_CONFIG` env var **Displaying progress in logs** - Added mdc dependency - Progress attached to MDC and included in logging format message - A default progress empty value is provided to avoid a KeyError when the progress field is not set, such as when logging from a different thread Here is what it looks like when we're hitting quota limits and getting some retries, it displays progress and colored logs:  Here is what it looks like when it runs smoothly:  **Tests** - Tested non regression with OpenAI API - Tested with Azure AI Resource Real Time `gpt-3.5-turbo` and `text-embedding-ada-002` deployment **Note**: this PR depends on ShishirPatil#381
aw632
pushed a commit
to vinaybagade/gorilla
that referenced
this pull request
Aug 22, 2024
…atil#384) **Logging config** - Colored logging using `coloredlogs` package - Logging configuration loaded from YAML config file, by default `logging.yaml` - Logging configuration YAML file location overridable with `LOGGING_CONFIG` env var **Displaying progress in logs** - Added mdc dependency - Progress attached to MDC and included in logging format message - A default progress empty value is provided to avoid a KeyError when the progress field is not set, such as when logging from a different thread Here is what it looks like when we're hitting quota limits and getting some retries, it displays progress and colored logs:  Here is what it looks like when it runs smoothly:  **Tests** - Tested non regression with OpenAI API - Tested with Azure AI Resource Real Time `gpt-3.5-turbo` and `text-embedding-ada-002` deployment **Note**: this PR depends on ShishirPatil#381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging config
coloredlogspackagelogging.yamlLOGGING_CONFIGenv varDisplaying progress in logs
Here is what it looks like when we're hitting quota limits and getting some retries, it displays progress and colored logs:
Here is what it looks like when it runs smoothly:
Tests
gpt-3.5-turboandtext-embedding-ada-002deploymentNote: this PR depends on #381