Skip to content

Conversation

@zhaoshengbo-source
Copy link
Contributor

The script automatically checks that every ModelConfig entry in model_config.py follows the rule:
If "FC" appears in the key, model_name, or display_name, then is_fc_model must be True.
Otherwise, is_fc_model should be False or unset.
If FC appears but is_fc_model=Flase , it will be reported as error,
if no FC appears but is_fc_model=True, it will be reported as a warning.

@ShishirPatil
Copy link
Owner

@zhaoshengbo-source I am wondering if rather than a script, do we just need a warn to catch this?
Given a model can have FC enabled, but might also be used in prompting mode, just a simple warn at run-time might suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants