fix(deploy): show version tag with commit hash in UI #254
Conversation
Format version as "v0.2 (e73fd1b)" instead of just the tag or SHA Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 597d565991
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Auto-detect git version: combine tag and SHA for display | ||
| GIT_TAG=$(git describe --tags --abbrev=0 2>/dev/null || echo "") | ||
| GIT_COMMIT=$(git rev-parse --short=7 HEAD 2>/dev/null || echo "dev") | ||
| if [ -n "$GIT_TAG" ]; then | ||
| export GIT_SHA="$GIT_TAG" | ||
| echo "📌 Building with tag: $GIT_SHA" | ||
| export GIT_SHA="${GIT_TAG} (${GIT_COMMIT})" |
There was a problem hiding this comment.
Using git describe --tags --abbrev=0 returns the most recent reachable tag even when the current commit is not tagged, so the UI will display a release tag for builds from commits ahead of that tag. This regresses the prior exact-match behavior and can mislead operators into thinking a dev build is an official release (the commit hash in parentheses doesn’t prevent the mistaken “version” label). If the intent is only to show the tag when the current commit is tagged, you need --exact-match (or equivalent) before formatting ${GIT_TAG} (${GIT_COMMIT}).
Useful? React with 👍 / 👎.
Summary
v0.2 (e73fd1b)instead of just the tag or SHAChanges
justfileto combine tag and commit hash forGIT_SHAbuild arg${GIT_TAG} (${GIT_COMMIT})when a tag exists