chore(db,docker): squash migration and compose config commits #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51978067a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Add migration for workflow_traces.error TEXT to JSONB - Add SECRET_STORE_MASTER_KEY to compose config Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
LuD1161
force-pushed
the
chore/squash-db-docker-commits
branch
from
5197806 to
8715b15
Compare
Contributor
Author
|
Thanks for catching this! Fixed in the latest push. The migration now uses a helper function
This ensures historical traces with structured errors (type, stack, details, fieldErrors) are preserved correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why these changes?
workflow_traces.error migration: The error field needs to store structured JSON data (stack traces, error metadata) rather than plain text. JSONB enables better querying and indexing of error information.
SECRET_STORE_MASTER_KEY: Required for encrypting sensitive data (API keys, credentials) stored in the secret store. Without this key, the secret encryption/decryption functionality won't work in Docker deployments.
Test plan