fix(docker): build workspace packages before frontend in Docker #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frontend's tsconfig.json uses TypeScript project references to packages/shared and packages/backend-client. Since commit f9ee4a3 enabled composite builds for faster type checking, these packages must be built before the frontend can compile. The dist/ folders are gitignored and don't exist in fresh Docker builds, causing TS6305 errors. This adds a step to build the required package declarations before the frontend build. Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The frontend's
tsconfig.jsonuses TypeScript project references topackages/sharedandpackages/backend-client. Since commit f9ee4a3 ("fast typecheck test") enabled composite builds for faster type checking, these packages must be built before the frontend can compile.The
dist/folders are gitignored and don't exist in fresh Docker builds, causing TS6305 errors like:Solution
Added
RUN cd /app && bunx tsc --build packages/shared packages/backend-clientbefore the frontend build step in the Dockerfile.Test plan
docker build --target backend -t studio-backend:test .✅docker build --target worker -t studio-worker:test .✅docker build --target frontend -t studio-frontend:test .✅