Skip to content

Commit

Permalink
[Dialogs] Fix actions order for center and justified actions alignmen…
Browse files Browse the repository at this point in the history
…t. (material-components#9889)

Fixing actions order for centered and justified aligned actions. The first action added now appears first on the trailing side for all alignments, except for leading alignment (Closes: #9890).

PiperOrigin-RevId: 300541039
  • Loading branch information
galiak11 authored Mar 12, 2020
1 parent 88ecf01 commit ba06140
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 22 deletions.
31 changes: 17 additions & 14 deletions components/Dialogs/src/private/MDCAlertControllerView+Private.m
Original file line number Diff line number Diff line change
Expand Up @@ -748,43 +748,46 @@ - (void)layoutHorizontalButtons:(NSArray<MDCButton *> *)buttons actionSize:(CGSi
(self.actionsInsets.left + self.actionsInsets.right);
CGPoint buttonOrigin = CGPointZero;
CGFloat buttonWidth = 0.f;
CGFloat multiplier = 1.f;
if (self.actionsHorizontalAlignment == MDCContentHorizontalAlignmentTrailing) {
buttonOrigin.x = self.actionsScrollView.contentSize.width - self.actionsInsets.right;
multiplier = -1.f;
CGFloat multiplier =
self.actionsHorizontalAlignment == MDCContentHorizontalAlignmentLeading ? 1.f : -1.f;
if (self.actionsHorizontalAlignment == MDCContentHorizontalAlignmentLeading) {
buttonOrigin.x = self.actionsInsets.left;
} else if (self.actionsHorizontalAlignment == MDCContentHorizontalAlignmentCenter) {
CGFloat actionWidthNoInsets =
actionSize.width - self.actionsInsets.left - self.actionsInsets.right;
buttonOrigin.x = (self.actionsScrollView.contentSize.width - actionWidthNoInsets) / 2.f;
} else { // leading or fill
buttonOrigin.x = self.actionsInsets.left;
buttonOrigin.x = ((self.actionsScrollView.contentSize.width - actionWidthNoInsets) / 2.f) +
actionWidthNoInsets;
} else { // trailing or justified
buttonOrigin.x = self.actionsScrollView.contentSize.width - self.actionsInsets.right;
}
buttonOrigin.y = self.actionsInsets.top;
for (UIButton *button in buttons) {
CGRect buttonRect = button.frame;

buttonWidth = buttonRect.size.width;

if (self.actionsHorizontalAlignment == MDCContentHorizontalAlignmentTrailing) {
buttonOrigin.x -= buttonRect.size.width;
} else if (self.actionsHorizontalAlignment == MDCContentHorizontalAlignmentJustified) {
if (self.actionsHorizontalAlignment == MDCContentHorizontalAlignmentJustified) {
if (buttons.count > 1) {
CGFloat totalMargin = self.actionsHorizontalMargin * (buttons.count - 1);
buttonWidth = (maxButtonWidth - totalMargin) / buttons.count;
} else {
buttonWidth = maxButtonWidth;
}
}

if (self.actionsHorizontalAlignment != MDCContentHorizontalAlignmentLeading) {
buttonOrigin.x += multiplier * buttonWidth;
}

buttonRect.origin = buttonOrigin;
buttonRect.size.width = buttonWidth;

button.frame = buttonRect;

if (button != buttons.lastObject) {
if (self.actionsHorizontalAlignment != MDCContentHorizontalAlignmentTrailing) {
buttonOrigin.x += buttonRect.size.width + self.actionsHorizontalMargin;
if (self.actionsHorizontalAlignment == MDCContentHorizontalAlignmentLeading) {
buttonOrigin.x += multiplier * (buttonWidth + self.actionsHorizontalMargin);
} else {
buttonOrigin.x -= self.actionsHorizontalMargin;
buttonOrigin.x += multiplier * self.actionsHorizontalMargin;
}
}
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit ba06140

Please sign in to comment.