Do not longer remove surrogates#1804
Merged
max-leuthaeuser merged 1 commit intomasterfrom Jan 13, 2025
Merged
Conversation
UTF8 characters can only be encoded using surrogates. By replacing them we lose most UTF8 emojis and such. If we ever encound actual unpaired surrogates on code we need a different fix.
johannescoetzee
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UTF8 characters can only be encoded using surrogates. By replacing them we lose most UTF8 emojis and such. If we ever encounter actual unpaired surrogates in customer code we need a different fix.
For: joernio/joern#5222