exclude fields from getting indexed by datastore #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 97.35% 93.19% -4.17%
==========================================
Files 1 1
Lines 227 235 +8
==========================================
- Hits 221 219 -2
- Misses 3 11 +8
- Partials 3 5 +2
|
Kami
reviewed
Sep 11, 2019
| var excludeIndex string | ||
| // use the Extension name is passed else derive it dynamically | ||
| if excludeFromIndexName != nil && len(excludeFromIndexName) > 0 { | ||
| excludeFromIndexExt = fmt.Sprintf("[%s]:true ", excludeFromIndexName[0]) |
There was a problem hiding this comment.
Interesting way to find an extension, works for me :)
…ame for excludig indexing of fields
Kami
reviewed
Sep 11, 2019
| @@ -18,21 +19,48 @@ import ( | |||
| ) | |||
|
|
|||
| // ProtoMessageToDatastoreEntity will generate an Entity Protobuf that datastore understands | |||
| func ProtoMessageToDatastoreEntity(src proto.Message, snakeCase bool, excludeFromIndex []string) (entity datastore.Entity, err error) { | |||
| func ProtoMessageToDatastoreEntity(src proto.Message, snakeCase bool, excludeFromIndexName ...string) (entity datastore.Entity, err error) { | |||
There was a problem hiding this comment.
I kinda missed that earlier, for explicitness sake, it wouldn't hurt if this argument is called excludeFromIndexOptionName or similar to make it clear that this expects extension option name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release adds support for excluding the fields from being indexed by google cloud datastore using a custom extension
in proto files.
Please note that
exclude only works with one extension