New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding to subscription keys #6

Merged

SherClockHolmes merged 1 commit into master from fixes/base64-sub-keys

Aug 2, 2017

Owner

SherClockHolmes commented Jul 28, 2017

Implementation of discussion from: #3. Suggestion by @EmpireJones.

Adds a decodeSubscriptionKey method to pad the base64 value
Removed cmd/webpush/ directory (wasn't being used)
Added "mailto:" format to sub claim when we set the vapid headers so the user only has to specify an email for Subscriber


          Adds decodeSubscriptionKey method to fix an issue with different fron…

d07aeef

…t end base64 encodings

SherClockHolmes added the bug label

SherClockHolmes mentioned this pull request

Fix "illegal base64 data at input byte X" error #3

Closed

SherClockHolmes merged commit cf20a3c into master

SherClockHolmes deleted the fixes/base64-sub-keys branch

August 2, 2017 16:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug