Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keys using standard base64 encoding, provide support for legacy GCM authorization #10

Merged

Conversation

froodian
Copy link
Contributor

@froodian froodian commented Feb 6, 2018

  • Check standard base64 encoding, then fall back to url encoding
  • Provide support for legacy GCM authorization header

Fixes #9. Also adds legacy GCM support as mentioned in #4 (comment) and the following comment.

…cy GCM authorization

* Check standard base64 encoding, then fallback to url encoding
* Provide support for legacy GCM authorization header
@anaskhan96
Copy link
Contributor

@SherClockHolmes pinging to see if you've noticed this PR.

@SherClockHolmes SherClockHolmes self-requested a review March 31, 2018 18:14
Copy link
Owner

@SherClockHolmes SherClockHolmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I tested this today and it looks good!

@SherClockHolmes SherClockHolmes merged commit 3382af2 into SherClockHolmes:master Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants