Fix short description change request 1452#1459
Open
emariam22 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the frontend sends a change request even when the user clicks save without making any edits.
Root Cause
The edit page compares values in component state with values returned from the API to determine if a resource was modified. However, many fields in state can be
undefinedwhile the API returns actual values (strings or null). This caused comparisons likeundefined !== "value"to always evaluate as true, incorrectly marking the resource as modified.Additionally,
short_descriptionwas being compared even though it is not editable on this page, which also contributed to false positives.Fix
short_descriptioncomparisonundefinedvalues:Testing
Tested using resource id 2:
Clicking Save without changes:
change_requestsrequest sentModifying a field:
change_requestsrequest is sent correctlyThis confirms the fix prevents false-positive change requests while preserving correct behavior.