Add example for various countries data #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prakriti-nith
commented
Aug 7, 2018
Prakriti-nith
commented
Prakriti-nith
force-pushed
the
add_example
branch
from
39db236 to
e48b4e5
Compare
Author
|
Should be reviewed after this PR gets merged. |
Author
|
@Shekharrajak ping! |
| <div class="panel-heading">Code to import data from API into <code>Daru::DataFrame</code> (yes, that's all!):</div> | ||
| <div class="panel-body"> | ||
| <%= | ||
| rouge(%{ |
Owner
There was a problem hiding this comment.
It would be better if we put these lines of code (in string) and use it in view (in all the places), isn't it ?
| 'Shows import from JSON API, charts, tables, and export', | ||
| 'Shows import from HTML pages, charts and tables' | ||
| 'Shows import from HTML pages, charts and tables', | ||
| 'Shows import from JSON API, multiple charts using PlotList, tables with formatters and CSS styling in HighCharts' |
| view_context.link_to('sciruby/repos', {action: 'repos', controller: 'sciruby_github'}, target: '_blank'), | ||
| view_context.link_to('sciruby/watchers', {action: 'watchers', controller: 'sciruby_github'}, target: '_blank'), | ||
| view_context.link_to('election/data', {action: 'data', controller: 'election'}, target: '_blank'), | ||
| view_context.link_to('countries', {action: 'data_countries', controller: 'countries'}, target: '_blank'), |
Owner
Shekharrajak
left a comment
Shekharrajak
left a comment
There was a problem hiding this comment.
Anything else you want to add in this PR @Prakriti-nith ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.