browser test cleanup#2039
Merged
Merged
Conversation
Contributor
|
the 14.x build issues appear to be a node v14.5.0 regression nodejs/node#34162, ignore those for the moment |
penguingovernor
suggested changes
Jul 1, 2020
penguingovernor
left a comment
penguingovernor
left a comment
There was a problem hiding this comment.
Looks good to me sans that one little debugging remnant, other than that good work (:
|
Cool thanks for doing this y'all! Looks great! |
saarCiklum
pushed a commit
to Folcon/js-xlsx
that referenced
this pull request
Aug 20, 2020
* browser test cleanup * add cases to core.js * apply feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser tests was missing ~77 (344) tests compared to the nodejs tests (421).
A lot of them were MFT tests, that I've added in
tests/fixtures.lstAfter adding the MFT tests, browser tests now covers 403 tests.