Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize LazyFrame schema resolution and distance computation #6

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Optimize LazyFrame schema resolution and distance computation #6

merged 2 commits into from
Mar 12, 2025
+8 −2

Conversation

amiralisahraei
Copy link
Contributor 

  • Replaced direct column access with collect_schema().names() to avoid PerformanceWarning.

  • Used pre-fetched column names for efficient distance computation.

  • Improves performance and resolves schema resolution warnings.

@amiralisahraei
refactor: fetch column names using collect_schema().names() to avoid …
3dca950 
…schema resolution warning

- Replaced direct column access with  to resolve column names efficiently.
- Avoids PerformanceWarning related to expensive schema resolution in LazyFrame.
@amiralisahraei
refactor: optimize distance computation by pre-fetching column names
4904733 
- Used pre-fetched column names to select subsets for distance computation.
- Improved performance by avoiding repeated schema resolution during column selection.
ShawhinT
ShawhinT approved these changes Mar 12, 2025
View reviewed changes
Copy link
Owner

@ShawhinT ShawhinT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for updating :)

@ShawhinT ShawhinT merged commit d8d19eb into ShawhinT:main Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShawhinT ShawhinT ShawhinT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amiralisahraei @ShawhinT