Correct IsCustomType extension method, add more tests to TypeExtensionsTest.cs #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| && !type.IsEnum && !type.IsValueType | ||
| && !type.IsPrimitive | ||
| && type != typeof(string) | ||
| && !type.GetInterfaces().Contains(typeof(IEnumerable)); |
There was a problem hiding this comment.
I guess that should be considered as breaking change. If someone is right now using e.g. List as Body parameter, after this change validation will stop working for this parameter.
Author
There was a problem hiding this comment.
Yes you're right. You can use any collection properties with custom type and add FluentValidation's validators for them, thank you for mention it in your issue
I relaxed checking by deleting the IEnumerable check
Member
|
Closing this one, will revisit the whole topic of supported types when designing v2. Thank you for your contributions @Tihomirov-Vasiliy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #31