feat(env_config): fix ROCm GPU detection for ROCm 7.2+#139
Merged
Conversation
Member
solderzzc
commented
Mar 8, 2026
solderzzc
commented
- Add amd-smi static --json as primary detection strategy (ROCm 6.3+/7.x)
- Keep rocm-smi as fallback for legacy ROCm <6.3
- Add multi-GPU selection: pick GPU with most VRAM, set HIP_VISIBLE_DEVICES
- Add _check_rocm_runtime() to verify ROCmExecutionProvider in onnxruntime (prevents CPU-only onnxruntime from shadowing onnxruntime-rocm)
- Update deploy.sh heuristic to also check for amd-smi
- Document GPU package conflict in requirements.txt
- Add 14 unit tests for all ROCm detection paths
- Add amd-smi static --json as primary detection strategy (ROCm 6.3+/7.x) - Keep rocm-smi as fallback for legacy ROCm <6.3 - Add multi-GPU selection: pick GPU with most VRAM, set HIP_VISIBLE_DEVICES - Add _check_rocm_runtime() to verify ROCmExecutionProvider in onnxruntime (prevents CPU-only onnxruntime from shadowing onnxruntime-rocm) - Update deploy.sh heuristic to also check for amd-smi - Document GPU package conflict in requirements.txt - Add 14 unit tests for all ROCm detection paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.