Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cronet for playback PR updated #41

Merged
merged 141 commits into from
Aug 25, 2023
Merged

Use cronet for playback PR updated #41

Changes from 1 commit
Commits
Show all changes
141 commits
Select commit Hold shift + click to select a range
4a278ef
Hide play queue button in VideoDetailsFragment mini player when the p…
TobiGr Oct 11, 2022
2f6cb87
Use GROUP_ALL_ID instead of hardcoded -1
Stypox Oct 27, 2022
57d2fe1
Fix duplicate videos in feed "All"
Stypox Oct 27, 2022
4b892e2
Update AppCompat to 1.5.1.
Isira-Seneviratne Aug 13, 2022
51bdc30
Use TextViewCompat.setCompoundDrawableTintList().
Isira-Seneviratne Jul 16, 2022
bf766f1
Update PrettyTime from 5.0.3 to 5.0.6 to include new localizations
TobiGr Nov 1, 2022
e333197
Use OnClickListener and OnLongClickListener lambdas in the player UIs.
Isira-Seneviratne Aug 27, 2022
8488739
Merge pull request #8655 from Isira-Seneviratne/Use_TextViewCompat_se…
Isira-Seneviratne Nov 3, 2022
e4f9746
Use lambdas for VideoDetailFragment listeners.
Isira-Seneviratne Aug 21, 2022
1de662f
Merge pull request #9272 from TeamNewPipe/prettytime
TobiGr Nov 3, 2022
c8caf48
Merge pull request #9230 from Stypox/duplicate-feed-videos
TobiGr Nov 3, 2022
c274ee9
Add changelog for 0.24.1 (991)
TobiGr Nov 3, 2022
e9870d9
Merge pull request #9286 from TeamNewPipe/changelog/0.24.1
TobiGr Nov 3, 2022
231c5e5
[YouTube] Support opening handles from external apps
AudricV Nov 3, 2022
9912c11
Update NewPipe Extractor to support handles
AudricV Nov 4, 2022
4573407
Merge pull request #9291 from AudricV/support-yt-handles-and-update-e…
TobiGr Nov 4, 2022
2c5c7df
Translated using Weblate (Punjabi)
weblate Nov 4, 2022
b066457
Update NewPipe to 0.24.1 (991)
TobiGr Nov 3, 2022
fc06159
Fix inconsistent channel group list and item view mode
Stypox Nov 4, 2022
49c12a3
Fix wrongly calculated channel groups span count
Stypox Nov 5, 2022
9472c36
Merge pull request #9109 from TeamNewPipe/fix/overlayPlayQueueButton
Stypox Nov 5, 2022
da61c9f
Merge pull request #9298 from Stypox/fix-inconsistent-channel-groups
TobiGr Nov 5, 2022
a95a5ed
Merge pull request #9290 from TeamNewPipe/release/0.24.1
TobiGr Nov 5, 2022
3dc1adb
Add helper methods for adding PendingIntent mutability.
Isira-Seneviratne Nov 7, 2022
bb83d2b
Translated using Weblate (Odia)
weblate Nov 8, 2022
ef35b36
Remove the redundant/overlapping toast "Copied to clipboard" for Andr…
dhruvpatidar359 Sep 11, 2022
7b7ab3f
Remove Utility.copyToClipboard and use ShareUtils.copyToClipboard ins…
AudricV Nov 8, 2022
6d812b8
Use Locale.forLanguageTag().
Isira-Seneviratne Aug 22, 2022
5c1af6d
Group private Localization methods together.
Isira-Seneviratne Nov 9, 2022
95a65d5
Merge pull request #9333 from Isira-Seneviratne/PendingIntent_mutability
Isira-Seneviratne Nov 9, 2022
feb03f7
Use Math.floorDiv().
Isira-Seneviratne Aug 15, 2022
ff774a1
Fix persistent hover overlay when mouse connected
han-sz Apr 30, 2022
cfda073
Fix DeX mode check
han-sz May 2, 2022
5e2ef7f
Address review comments
han-sz May 2, 2022
a1773d1
Fix JSDoc checkstyle warning
han-sz May 3, 2022
88eed6c
Add JSDoc comment and a performance note for `isDesktopMode`
han-sz May 4, 2022
9e5c68c
Add check for input devices with cursor.
cybersphinx Jul 11, 2022
d2b6bda
Remove errant return.
cybersphinx Jul 16, 2022
c38f150
Remove now obsolete API check.
cybersphinx Jul 16, 2022
abf1cc5
Improve code of DeviceUtils.isDesktopMode
AudricV Nov 9, 2022
ef1e7e5
Merge branch 'master' into dev
TobiGr Nov 9, 2022
1673290
Translated using Weblate (Punjabi)
ShareASmile Nov 8, 2022
5804483
Translated using Weblate (Czech)
Nov 8, 2022
289f910
Translated using Weblate (Italian)
pjammo Nov 8, 2022
a4e883c
Translated using Weblate (Latvian)
Coool Nov 8, 2022
747df59
Translated using Weblate (Latvian)
Coool Nov 8, 2022
95c32d6
Merge remote-tracking branch 'Weblate/dev' into dev
TobiGr Nov 9, 2022
627c6e2
Merge pull request #8316 from han-sz/fix_video_mouse_hover_overlay
TobiGr Nov 9, 2022
aad5e26
Merge pull request #8870 from Isira-Seneviratne/Locale_forLanguageTag
Isira-Seneviratne Nov 10, 2022
a40f035
Merge branch 'dev' into Refactor_VideoDetailFragment
Isira-Seneviratne Nov 14, 2022
a798979
Merge branch 'dev' into Refactor_VideoPlayerUi
Isira-Seneviratne Nov 14, 2022
048b097
Set compileSdk and targetSdk to 33 (Android 13)
Stypox Nov 5, 2022
8db90ba
Use SparseArrayCompat for thumbnails.
Isira-Seneviratne Aug 22, 2022
d661700
Use SparseArrayCompat instead of SparseArray in StreamItemAdapter.
Isira-Seneviratne Nov 22, 2022
e5af1c9
Seeking no longer pauses the played video
Jared234 Nov 26, 2022
44bc6bf
Set image-minimizer to specify image width ...
goyalyashpal Nov 26, 2022
225f69b
Fix value of width
goyalyashpal Nov 26, 2022
6b89b44
Merge pull request #8961 from dhruvpatidar359/Toast-Popup
AudricV Nov 26, 2022
7c1d06e
Resolve scoping issue to get values of probeResult
goyalyashpal Nov 26, 2022
e9ef945
Minimize not-so-long images too
goyalyashpal Nov 26, 2022
f2e3020
checkstyle: declare org.jetbrains and javax.annotation Nullable's and…
evermind-zz Nov 28, 2022
bce77aa
Block rxjava3 nullable/nonnull imports in checkstyle
Stypox Nov 28, 2022
60671c9
Merge pull request #9474 from bravenewpipe/avoid-wrong-nullable-notnu…
Stypox Nov 28, 2022
2984649
Merge pull request #9471 from yashpalgoyal1304/set-width-image-minimizer
TobiGr Nov 28, 2022
f07886f
Add notifications permission
Stypox Nov 28, 2022
9d01d88
Request permission to send notifications
Stypox Nov 28, 2022
2bf58ab
Make miniplayer close button area larger
Stypox Nov 29, 2022
0590350
Merge pull request #8743 from shivambeohar/8615-gap-at-miniplayer-clo…
Stypox Nov 29, 2022
b0516fb
Use BitmapCompat.createScaledBitmap().
Isira-Seneviratne Jul 24, 2022
72a250b
Merge pull request #9479 from Stypox/create-scaled-bitmap
Stypox Nov 29, 2022
8282b8a
Update Sonarqube to 3.5
TacoTheDank Nov 29, 2022
bd6b3c5
Merge pull request #9480 from TacoTheDank/bumpSonar
Stypox Nov 29, 2022
a2f2d56
Disabling night theme selection if auto theme is not used
Jared234 Dec 1, 2022
074a8ff
Update Desugaring to 1.1.8
TacoTheDank Dec 2, 2022
1d53389
Translated using Weblate (Norwegian Bokmål)
weblate Dec 3, 2022
f1b15a9
Show toast when no updates are available.
Isira-Seneviratne Jul 20, 2022
6b210e1
Apply ktlint formatting.
Isira-Seneviratne Oct 10, 2022
730664e
Merge pull request #8668 from Isira-Seneviratne/Show_no_update_notifi…
Stypox Dec 4, 2022
869d46f
rename help to fast mode
pratyaksh1610 Dec 4, 2022
77737a5
Merge pull request #9500 from pratyaksh1610/branch_9348
Stypox Dec 4, 2022
9c4d552
Merge pull request #8810 from Isira-Seneviratne/Math_floorDiv
Stypox Dec 4, 2022
e5f30a0
Only show "Enqueue next" when in the middle of the queue
Douile Aug 25, 2022
281ac13
Merge pull request #8883 from Douile/dev-enqueue-next-hide
Stypox Dec 4, 2022
3103fd7
Rename list_empty_subtitle string
Stypox Dec 4, 2022
10977ea
Show hint about how to import subscriptions when there are none
Stypox Dec 4, 2022
4022544
Center text in empty views
Stypox Dec 4, 2022
3bb5187
Merge pull request #9501 from Stypox/import-subscriptions-hint
Stypox Dec 4, 2022
0923594
Added option to download items in the queue
Jared234 Dec 4, 2022
86ee94e
show subscriber count on player page
Theta-Dev Sep 28, 2022
0df6967
Make subscribers in video detail fragment dimmer
Stypox Dec 4, 2022
a6f57a8
Merge pull request #9173 from Theta-Dev/video-sub-count
Stypox Dec 4, 2022
a4c9e0a
Remove dead Privacy Tools instance (#9504)
dngray Dec 5, 2022
4a27d37
Merge pull request #9504 from dngray/pr-remove_privacytools
TobiGr Dec 5, 2022
5fc85fa
Implemented suggestions
Jared234 Dec 5, 2022
161007f
Merge branch 'dev' into Refactor_VideoPlayerUi
Isira-Seneviratne Dec 6, 2022
c7d392e
Merge branch 'dev' into Refactor_VideoDetailFragment
Isira-Seneviratne Dec 6, 2022
8edfafc
Translated using Weblate (Spanish)
weblate Dec 8, 2022
7c5b451
Update RxJava to 3.1.5.
Isira-Seneviratne Nov 26, 2022
c537776
Fixes #9518
pratyaksh1610 Dec 9, 2022
0c47fc7
Delete translation without default: app_update_notification_content_text
TobiGr Dec 9, 2022
d70b768
Delete translation without default: app_update_notification_content_text
TobiGr Dec 9, 2022
26579cc
Delete translation without default: app_update_notification_content_t…
TobiGr Dec 9, 2022
9eb72d5
Delete translation without default: progressive_load_interval_default
TobiGr Dec 9, 2022
5942add
Merge pull request #9522 from TeamNewPipe/update-translations
TobiGr Dec 9, 2022
1279692
Removed the wasPlaying variable
Jared234 Dec 10, 2022
eea4f0f
Update ExoPlayer to 2.18.2
Dec 16, 2022
d255d3e
added icon for play all
pratyaksh1610 Dec 17, 2022
dfc46c3
Support audio only background for services only supporting video streams
evermind-zz Dec 16, 2022
5d9bf80
Translated using Weblate (French)
weblate Dec 25, 2022
c13b858
Add Nynorsk (nn) to the language chooser
TobiGr Dec 22, 2022
b07f1a7
Merge pull request #9596 from TeamNewPipe/update-localization
TobiGr Dec 25, 2022
fcac53c
Merge pull request #9488 from Jared234/9353_night_theme_selection
TobiGr Dec 25, 2022
231e677
Merge pull request #8895 from Isira-Seneviratne/SparseArrayCompat
Stypox Dec 28, 2022
fb1360b
Use ListAdapter in NotificationModeConfigAdapter.
Isira-Seneviratne Aug 18, 2022
69e8e4d
Merge pull request #9306 from Stypox/target-api-33
Stypox Dec 31, 2022
8078620
Merge pull request #9481 from TacoTheDank/bumpDesugaring
Stypox Dec 31, 2022
413a1b5
Refactor constrolsTouchListener code
Stypox Dec 31, 2022
9797803
Activate on click listeners only when not loading
Stypox Dec 31, 2022
be856f7
Merge pull request #8847 from Isira-Seneviratne/Refactor_VideoDetailF…
Stypox Dec 31, 2022
661cd4c
Merge pull request #9159 from Isira-Seneviratne/Refactor_VideoPlayerUi
Stypox Dec 31, 2022
367ece8
Merge pull request #9496 from Jared234/9437_continue_playing_while_se…
Stypox Dec 31, 2022
b3bfec9
Use correct fragment manager for download dialog
Stypox Dec 31, 2022
27f6c3b
Merge pull request #9502 from Jared234/8585_download_in_queue
Stypox Dec 31, 2022
d21fac6
Remove playlist details toasts
Stypox Dec 31, 2022
6af2242
Merge pull request #9521 from pratyaksh1610/branch-9518
Stypox Dec 31, 2022
56800c2
Update rxandroid from 3.0.0 to 3.0.2
Stypox Jan 1, 2023
4642477
Merge pull request #9520 from Isira-Seneviratne/Update_RxJava
Stypox Jan 1, 2023
cd0e585
Merge pull request #9568 from pratyaksh1610/branch-add-play-all-icon
Stypox Jan 1, 2023
f4a5b3b
set 'playback in background button' visible if there are videostreams
evermind-zz Jan 1, 2023
7988fe0
Use new NewPipe Extractor Utils methods.
Isira-Seneviratne Aug 13, 2022
f17155b
Merge branch 'TeamNewPipe:dev' into exo182
Redirion Jan 2, 2023
b1d9080
Simplify disposables handling in notification mode settings
Stypox Jan 2, 2023
b6488fe
Merge pull request #8841 from Isira-Seneviratne/Notification_mode_Lis…
Stypox Jan 2, 2023
7454b31
Merge pull request #9562 from bravenewpipe/use-videostream-for-audio-…
Stypox Jan 2, 2023
8fa9495
Merge pull request #8769 from Isira-Seneviratne/New_Utils_methods
Stypox Jan 2, 2023
1bb166a
Merge pull request #9553 from Redirion/exo182
Stypox Jan 2, 2023
92ba284
Use Cronet for playback, replace YouTube custom DataSource by a Resol…
AudricV Sep 14, 2022
17d5188
Add custom UserAgent class to allow using QUIC
AudricV Jan 3, 2023
cb599fc
Remove UserAgent from cronet-common via Gradle tasks
Stypox Jan 3, 2023
f874b7a
Enable QUIC and Brotli support for playback
AudricV Dec 5, 2022
a5a4a94
Remove any reference to user data in cronet's UserAgent
Stypox Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
set 'playback in background button' visible if there are videostreams
  • Loading branch information
@evermind-zz
evermind-zz committed Jan 1, 2023
commit f4a5b3bcbf2e04ee860a9b906f8471f65eb69468
5 changes: 3 additions & 2 deletions app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,8 +1666,9 @@ public void handleResult(@NonNull final StreamInfo info) {

binding.detailControlsDownload.setVisibility(
StreamTypeUtil.isLiveStream(info.getStreamType()) ? View.GONE : View.VISIBLE);
binding.detailControlsBackground.setVisibility(info.getAudioStreams().isEmpty()
? View.GONE : View.VISIBLE);
binding.detailControlsBackground.setVisibility(
info.getAudioStreams().isEmpty() && info.getVideoStreams().isEmpty()
? View.GONE : View.VISIBLE);

final boolean noVideoStreams =
info.getVideoStreams().isEmpty() && info.getVideoOnlyStreams().isEmpty();
Expand Down