Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playlist name and video name in playlist sharing content #30

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

ShareASmile
Copy link
Owner

@ShareASmile ShareASmile commented Jun 21, 2024

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Add playlist name and video name in playlist sharing content

Currently, only a list of videos separated by newline are added in
the share content.
This makes it difficult to identify a specific video in a list of
Urls.
Used string resources for the sharing content formats.
Added a confirmation dialog for users to choose between sharing
playlist formats.
Added Playlist name as the header and corresponding video name for
each video Url in following format.

Testing apk

Newpipe-add-playlist-n-video-name-when-share.zip

Agreement

Co-Authored-By: Siddhesh Naik <87667048+snaik20@users.noreply.github.com>
@ShareASmile ShareASmile merged commit b776584 into flora Jun 22, 2024
1 check passed
Repository owner locked and limited conversation to collaborators Jun 22, 2024
@ShareASmile ShareASmile deleted the playlist-sharing-update branch June 22, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant