Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation error - wrong param count in Http client adapter test file #355

Closed
ururk opened this issue Jun 17, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working to be released PR exists or in master, but not released yet
Milestone

Comments

@ururk
Copy link

ururk commented Jun 17, 2023

/library/Zend/Http/Client/Adapter/Test.php

    /**
     * Connect to the remote server
     *
     * @param string  $host
     * @param int     $port
     * @param boolean $secure
     * @param int     $timeout
     * @throws Zend_Http_Client_Adapter_Exception
     */
    public function connect($host, $port = 80, $secure = false)

Four params are documented, but the function only take three. Obviously, this function doesn't do much - as stated at the top without actually performing an HTTP request.. Not critical, but noticed it.

@develart-projects develart-projects added the bug Something isn't working label Aug 9, 2023
@develart-projects develart-projects added this to the 1.23.0 milestone Aug 10, 2023
@develart-projects develart-projects added the to be released PR exists or in master, but not released yet label Aug 10, 2023
develart-projects added a commit to develart-projects/zf1-future that referenced this issue Aug 10, 2023
@develart-projects
Copy link
Collaborator

#364

@develart-projects develart-projects self-assigned this Aug 10, 2023
@develart-projects
Copy link
Collaborator

1.23.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to be released PR exists or in master, but not released yet
Projects
None yet
Development

No branches or pull requests

2 participants