Figure 5.3 change #143
Merged
Figure 5.3 change #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this should be better and closer to the original one as the X axis should start from 1 and the Y axis should be limited to 5. Besides, I don't know why the line 367 and the line 369 were commented, so I uncommented them. I added more description to the Y label too.
Now the colour is also correspond to the figure in the book.
|
Thanks a lot for the contribution! |
|
My pleasure. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes some details which I think cannot be ignored, including axis, color, description.
Originally, the x axis starts from 0, but this doesn't make sense. So I changed it to start from 1. I also set the y axis limit to 5.
Before:
Now:
And I think the new one is closer to the one in the book: