Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement user triggered screenshots #915

Conversation

MohabMohie
Copy link
Contributor

@MohabMohie MohabMohie commented Feb 26, 2023

Signed-off-by: MohabMohie <Mohab.MohieElDeen@outlook.com>
@MohabMohie MohabMohie added enhancement New feature or request java Pull requests that update Java code labels Feb 26, 2023
@MohabMohie MohabMohie self-assigned this Feb 26, 2023
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #915 (5998c9a) into master (f8a84c0) will increase coverage by 0.67%.
The diff coverage is 58.97%.

@@             Coverage Diff              @@
##             master     #915      +/-   ##
============================================
+ Coverage     38.43%   39.10%   +0.67%     
- Complexity      957      969      +12     
============================================
  Files            88       89       +1     
  Lines          9024     9043      +19     
  Branches        958      959       +1     
============================================
+ Hits           3468     3536      +68     
+ Misses         5049     4983      -66     
- Partials        507      524      +17     
Impacted Files Coverage Δ
...hafthq/shaft/gui/element/ElementActionsHelper.java 50.64% <0.00%> (ø)
.../shafthq/shaft/properties/PropertyFileManager.java 44.94% <0.00%> (+3.27%) ⬆️
...hq/shaft/tools/io/helpers/ReportManagerHelper.java 63.38% <ø> (ø)
...hub/shafthq/shaft/gui/image/ScreenshotManager.java 35.51% <44.44%> (+0.53%) ⬆️
...fthq/shaft/driver/helpers/DriverFactoryHelper.java 34.32% <61.11%> (-1.08%) ⬇️
...hafthq/shaft/gui/browser/FluentBrowserActions.java 72.46% <66.66%> (+1.03%) ⬆️
src/main/java/com/shaft/driver/DriverFactory.java 38.88% <100.00%> (ø)
...ava/io/github/shafthq/shaft/enums/Screenshots.java 100.00% <100.00%> (ø)
...hafthq/shaft/gui/element/FluentElementActions.java 37.50% <100.00%> (+1.45%) ⬆️
...thub/shafthq/shaft/gui/image/ScreenshotHelper.java 91.01% <100.00%> (+3.77%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MohabMohie
Copy link
Contributor Author

@MahmoudElSharkawy clean PR, kindly review and merge.

@MohabMohie MohabMohie added this pull request to the merge queue Feb 26, 2023
Merged via the queue into master with commit b848e5e Feb 26, 2023
@MohabMohie MohabMohie deleted the 899-feature-request-need-to-be-able-to-take-and-attach-a-screenshot-page-snapshot-on-demand-as-a-browser-action branch February 26, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java Pull requests that update Java code
Projects
None yet
2 participants