Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate hover action to new structure #1464

Merged
merged 1 commit into from
Jan 22, 2024
Merged

migrate hover action to new structure #1464

merged 1 commit into from
Jan 22, 2024

Conversation

MohabMohie
Copy link
Contributor

  • implement hover action type under new structure
  • implement mocked hover tests (inside and outside viewport horizontally and vertically)

- implement hover action type under new structure
- implement mocked hover tests (inside and outside viewport horizontally and vertically)
@MohabMohie MohabMohie added enhancement New feature or request java Pull requests that update Java code labels Jan 22, 2024
@MohabMohie MohabMohie self-assigned this Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 320 lines in your changes are missing coverage. Please review.

Comparison is base (6b71101) 51.01% compared to head (3918577) 50.85%.
Report is 2 commits behind head on main.

Files Patch % Lines
...er/internal/DriverFactory/DriverFactoryHelper.java 34.83% 46 Missing and 12 partials ⚠️
...om/shaft/gui/internal/image/ScreenshotManager.java 45.91% 37 Missing and 16 partials ⚠️
...m/shaft/gui/internal/image/AnimatedGifManager.java 10.34% 50 Missing and 2 partials ⚠️
...ava/com/shaft/gui/element/AsyncElementActions.java 18.51% 22 Missing ⚠️
src/main/java/com/shaft/driver/DriverFactory.java 34.48% 16 Missing and 3 partials ⚠️
src/main/java/com/shaft/db/DatabaseActions.java 0.00% 18 Missing ⚠️
...com/shaft/gui/internal/image/ScreenshotHelper.java 72.72% 8 Missing and 7 partials ⚠️
...a/com/shaft/listeners/CucumberFeatureListener.java 0.00% 14 Missing ⚠️
...shaft/listeners/internal/TestNGListenerHelper.java 61.29% 6 Missing and 6 partials ⚠️
.../main/java/com/shaft/gui/element/TouchActions.java 16.66% 9 Missing and 1 partial ⚠️
... and 19 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1464      +/-   ##
============================================
- Coverage     51.01%   50.85%   -0.16%     
+ Complexity     1314     1286      -28     
============================================
  Files           108      108              
  Lines         10191    10069     -122     
  Branches       1019     1006      -13     
============================================
- Hits           5199     5121      -78     
+ Misses         4355     4324      -31     
+ Partials        637      624      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MustafaAgamy MustafaAgamy merged commit fa23a5b into main Jan 22, 2024
24 of 26 checks passed
@MustafaAgamy MustafaAgamy deleted the hoverEnhancements branch January 22, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants