Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1326 bug draganddrop action fails due to not locating the element correctly after the action takes place #1389

Conversation

MohabMohie
Copy link
Contributor

No description provided.

Note: drag and drop works well for web.
Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
- upgraded from 4.12.1 to 4.15.0

Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
- issue is already fixed by implementing the drag and drop flag (defaults to false) in an earlier release.

Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
@MohabMohie MohabMohie marked this pull request as ready for review December 6, 2023 21:00
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (59962e4) 29.20% compared to head (ff2a98b) 14.80%.
Report is 1 commits behind head on main.

Files Patch % Lines
...com/shaft/gui/internal/image/ScreenshotHelper.java 0.00% 61 Missing ⚠️
...ain/java/com/shaft/gui/browser/BrowserActions.java 0.00% 8 Missing ⚠️
...aft/gui/element/internal/ElementActionsHelper.java 0.00% 7 Missing ⚠️
...om/shaft/gui/internal/image/ScreenshotManager.java 0.00% 4 Missing ⚠️
...ain/java/com/shaft/gui/element/ElementActions.java 0.00% 3 Missing ⚠️
...m/shaft/validation/internal/ValidationsHelper.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1389       +/-   ##
=============================================
- Coverage     29.20%   14.80%   -14.41%     
+ Complexity      697      377      -320     
=============================================
  Files           106      106               
  Lines         10264    10275       +11     
  Branches       1072     1068        -4     
=============================================
- Hits           2998     1521     -1477     
- Misses         6716     8484     +1768     
+ Partials        550      270      -280     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohabMohie MohabMohie merged commit b22dd43 into main Dec 6, 2023
4 of 22 checks passed
@MohabMohie MohabMohie deleted the 1326-bug-draganddrop-action-fails-due-to-not-locating-the-element-correctly-after-the-action-takes-place branch December 6, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DragAndDrop Action Fails due to not locating the element correctly after the action takes place
1 participant