Add unit tests for domain manager

Shaddoll · Oct 22, 2024 · 35bf9fd · 35bf9fd
1 parent 675049b
commit 35bf9fd
Show file tree

Hide file tree

Showing 5 changed files with 828 additions and 7 deletions.
diff --git a/common/persistence/client/factory.go b/common/persistence/client/factory.go
@@ -232,7 +232,7 @@ func (f *factoryImpl) NewDomainManager() (p.DomainManager, error) {
 	if err != nil {
 		return nil, err
 	}
-	result := p.NewDomainManagerImpl(store, f.logger)
+	result := p.NewDomainManagerImpl(store, f.logger, p.NewPayloadSerializer())
 	if errorRate := f.config.ErrorInjectionRate(); errorRate != 0 {
 		result = errorinjectors.NewDomainManager(result, errorRate, f.logger)
 	}

diff --git a/common/persistence/data_store_interfaces.go b/common/persistence/data_store_interfaces.go
@@ -32,7 +32,7 @@ import (
 	"github.com/uber/cadence/common/types"
 )
 
-//go:generate mockgen -package $GOPACKAGE -destination data_store_interfaces_mock.go -self_package github.com/uber/cadence/common/persistence github.com/uber/cadence/common/persistence ExecutionStore,ShardStore
+//go:generate mockgen -package $GOPACKAGE -destination data_store_interfaces_mock.go -self_package github.com/uber/cadence/common/persistence github.com/uber/cadence/common/persistence ExecutionStore,ShardStore,DomainStore
 //go:generate mockgen -package $GOPACKAGE -destination visibility_store_mock.go -self_package github.com/uber/cadence/common/persistence github.com/uber/cadence/common/persistence VisibilityStore
 
 type (

diff --git a/common/persistence/data_store_interfaces_mock.go b/common/persistence/data_store_interfaces_mock.go
diff --git a/common/persistence/domainManager.go → common/persistence/domain_manager.go b/common/persistence/domainManager.go → common/persistence/domain_manager.go
@@ -39,12 +39,10 @@ type (
 	}
 )
 
-var _ DomainManager = (*domainManagerImpl)(nil)
-
 // NewDomainManagerImpl returns new DomainManager
-func NewDomainManagerImpl(persistence DomainStore, logger log.Logger) DomainManager {
+func NewDomainManagerImpl(persistence DomainStore, logger log.Logger, serializer PayloadSerializer) DomainManager {
 	return &domainManagerImpl{
-		serializer:  NewPayloadSerializer(),
+		serializer:  serializer,
 		persistence: persistence,
 		logger:      logger,
 	}
@@ -168,6 +166,7 @@ func (m *domainManagerImpl) ListDomains(
 			FailoverNotificationVersion: d.FailoverNotificationVersion,
 			PreviousFailoverVersion:     d.PreviousFailoverVersion,
 			NotificationVersion:         d.NotificationVersion,
+			LastUpdatedTime:             d.LastUpdatedTime.UnixNano(),
 		}
 		if d.FailoverEndTime != nil {
 			currResp.FailoverEndTime = common.Int64Ptr(d.FailoverEndTime.UnixNano())