Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _Projection class #81

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Conversation

abhi-glitchhg
Copy link
Member

We can replace _Projection class with a one-liner if-else statement.

Should we replace it with if-else or should we keep the current implementation?

cc: @NeelayS @aditya-agrawal-30502 @alvanli

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #81 (a7637d9) into main (aec005b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         1880      1872    -8     
=========================================
- Hits          1880      1872    -8     
Impacted Files Coverage Δ
vformer/attention/cross.py 100.00% <100.00%> (ø)

@NeelayS
Copy link
Member

NeelayS commented Mar 25, 2022

@aditya-agrawal-30502 You had worked on this implementation, right? Were there any reasons behind making it a class?

@aditya-agrawal-30502
Copy link
Contributor

It was just that i needed a linear projection and had to use it a couple times so made a class of it.
There was no implementation of it before so hence needed

@NeelayS
Copy link
Member

NeelayS commented Mar 31, 2022

I see. Since it's only a couple of times, we can remove it I guess. What you think, @abhi-glitchhg?

@abhi-glitchhg
Copy link
Member Author

I see. Since it's only a couple of times, we can remove it I guess. What you think, @abhi-glitchhg?

yes,

@NeelayS NeelayS changed the title Removed _Projection class Remove _Projection class Mar 31, 2022
@NeelayS
Copy link
Member

NeelayS commented Mar 31, 2022

Cool, merging.

@NeelayS NeelayS merged commit ec7238f into SforAiDl:main Mar 31, 2022
@abhi-glitchhg abhi-glitchhg deleted the remove_projection branch April 2, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants