Add Video Vision Transformer implementation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 59 61 +2
Lines 1696 1749 +53
=========================================
+ Hits 1696 1749 +53
|
NeelayS
changed the title
…n series) with simple linear embedding..
NeelayS
requested changes
Feb 1, 2022
tests/test_encoder.py
Outdated
|
|
||
|
|
||
| def test_TubeletEmbedding(): | ||
| from vformer.encoder.embedding.video_patch_embeddings import TubeletEmbedding |
There was a problem hiding this comment.
Can you please move this import to the top of the file since we've been doing that for the rest of the test functions?
tests/test_models.py
Outdated
| @@ -496,3 +496,26 @@ def test_ConvVT(): | |||
| out = model(img2) | |||
| assert out.shape == torch.Size([4, 1000]) | |||
| del model | |||
|
|
|||
|
|
|||
| def test_Vivit(): | |||
There was a problem hiding this comment.
Suggested change
| def test_Vivit(): | |
| def test_ViViT(): |
|
Hi @abhi-glitchhg, I have added a couple of suggestions.
Thanks. |
NeelayS
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26