Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI Improvements #48

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Commits on Nov 24, 2022

  1. Configuration menu
    Copy the full SHA
    979d760 View commit details
    Browse the repository at this point in the history
  2. Ensure greeting is first text printed

    Even when the config is invalid, the welcome message should be printed.
    Amphitryon0 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    d534061 View commit details
    Browse the repository at this point in the history
  3. Delay instruction to leave the program open

    We shouldn't print this if some checks might result in immediately
    closing the program.
    Amphitryon0 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    cee34c7 View commit details
    Browse the repository at this point in the history
  4. Use more verbose messages when loading local PB

    This gives more context for the "You did not set a new PB." message that
    normally appears at startup. Also, the explanation when we ignore PB.txt
    now appears even when it doesn't contain a number.
    Amphitryon0 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    864932e View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. Configuration menu
    Copy the full SHA
    1d295b7 View commit details
    Browse the repository at this point in the history
  2. Clarify new branch message

    This is intended to address some user confusion about what the number
    represents (some people thought it had to do with the contents of the
    branch and were worried about it being the same between threads) and
    whether the message is important or not (some people thought that
    numbers not printed had some checks being skipped and even worried that
    PBs would not be found on these branches).
    Amphitryon0 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    d2504b7 View commit details
    Browse the repository at this point in the history
  3. Print log statements all at once

    This prevents a fairly common problem where two log lines can end up
    interleaved.
    Amphitryon0 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    5f92e3c View commit details
    Browse the repository at this point in the history
  4. Ensure manual selection mode never restarts

    It was technically possible to perform 100,000 moves and then restart.
    More realistically, this change is mainly useful if someone lowers the
    default iteration limit.
    Amphitryon0 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    44004c7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    46c1313 View commit details
    Browse the repository at this point in the history
  6. Simplify iterations log message

    The extra information about steps and frames was extremely confusing to
    users and, as a pure debugging feature, was inappropriate at log level 3,
    if not even at log level 6.
    Amphitryon0 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    3db180b View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2022

  1. Configuration menu
    Copy the full SHA
    1071d17 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2022

  1. Fix worker count logic

    This was accidentally checking for the Random move selection method
    instead of Manual.
    Amphitryon0 committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    22071c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Configuration menu
    Copy the full SHA
    122adfd View commit details
    Browse the repository at this point in the history
  2. Improve system-specific clean shutdown support

    Windows does not generate SIGTERM when closing a program, and it
    actually doesn't support SIGINT either; it may work, but correct
    behavior is not guaranteed.
    Amphitryon0 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    866e74d View commit details
    Browse the repository at this point in the history
  3. Handle all Windows signals correctly

    Using Ctrl+Break to shut down and closing the window both resulted in
    instant termination.
    Amphitryon0 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    16c3d7b View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Only allow uploading the best record available

    This check prevents now obsoleted records from being submitted, as the
    thread with the actual record either already has returned or will at
    some point.
    Amphitryon0 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    cdbf56d View commit details
    Browse the repository at this point in the history