forked from Azure/azure-cli-extensions
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/security context #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/approve wildcards
…-wide making layer caching work across multiple container groups
…-extensions into feature/security_context
adding capabilities array for ARM input
…landsworth/azure-cli-extensions into feature/security_context
adding a couple bug fixes for using sha hashes
src/confcom/azext_confcom/tests/latest/test_confcom_scenario.py
Outdated
Show resolved
Hide resolved
SethHollandsworth
requested changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few quick things to fix, style check and tests both pass on my computer 👍
SethHollandsworth
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SethHollandsworth
added a commit
that referenced
this pull request
May 16, 2023
…python (Azure#6144) * changing version number naming scheme and bugfix for 32bit python * addressing PR comments * moving where pulling files happens from * making a sha256 hash of the security policy print out when injecting into arm template * taking out the --json option * removing unused function * adding warnings for save to file and debug mode. fixed bug with numbers for template parameters * taking out unused function and fixing style checks * adding error checking back in for when dmverity-vhd returns nothing * making it so you can disable allow_elevated via the privileged field in the arm template * Feature/security context (#18) * securityContext --------- Co-authored-by: Seth Hollandsworth <seth.hollandsworth@gmail.com> Co-authored-by: Seth Hollandsworth <sethho@microsoft.com> * changing default value of no_new_privileges * updating tests * taking allow_elevated out of expected fields in ARM template * adding docs for dmverity hashing and fixing markdown styling --------- Co-authored-by: Heather Garvison <hgarvison@microsoft.com>
SethHollandsworth
pushed a commit
that referenced
this pull request
Aug 14, 2024
* fix: --title --kind --custom-property parameters (#1) * feat: support yaml file in register command (#3) * fix: workspace parameter should not be required (#2) * style: fix lint issues (#6) * chore: update codeowner for apic-extension (#5) * feat: revert changes to min cli version (#4) * feat: resolve comments to CLI experience (#10) * feat: mark "apic api register" command as preview (#13) * feat: remove --terms-of-service parameter (#12) * feat: remove --workspace-name parameter (#11) * feat: support python 3.8 and 3.9 (#14) * feat: fix command descriptions (#17) * tests: add test cases for 'apic service' commands (#16) * feat: Use 03-01 spec from azure-rest-api-specs repo to regenerate CLI (#19) * fix: CLI errors (#20) * fix: import error when run CLI command * fix: no workspace name error when run import specification command * feat: mark some parameters as required (#21) * feat: mark --assignments parameter required for metadata commands * doc: update sample commands * feat: mark --source-resource-ids parameter as required for import-from-apim command * doc: update description for import-from-apim command * feat: bump version to 1.0.0b5 and update changelog (#18) * build: fix ci (#22) * style: fix style warnings * test:fix test cases * fix: service update command failure (#28) * doc: fix command samples (#30) * doc: update changelog per feedback (#29) * doc: remove extra spaces in register command help message (#34) * doc: update api definition and metadata command samples (#36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.