Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/security context #18

Merged
merged 51 commits into from
Apr 27, 2023
Merged

Feature/security context #18

merged 51 commits into from
Apr 27, 2023

Conversation

hgarvison
Copy link
Collaborator

@hgarvison hgarvison commented Mar 10, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

SethHollandsworth and others added 25 commits March 3, 2023 14:57
…-wide

making layer caching work across multiple container groups
adding capabilities array for ARM input
@hgarvison hgarvison self-assigned this Mar 10, 2023
Copy link
Owner

@SethHollandsworth SethHollandsworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few quick things to fix, style check and tests both pass on my computer 👍

src/confcom/azext_confcom/container.py Outdated Show resolved Hide resolved
src/confcom/azext_confcom/container.py Outdated Show resolved Hide resolved
src/confcom/azext_confcom/container.py Outdated Show resolved Hide resolved
src/confcom/azext_confcom/container.py Outdated Show resolved Hide resolved
src/confcom/azext_confcom/data/internal_config.json Outdated Show resolved Hide resolved
src/confcom/azext_confcom/security_policy.py Show resolved Hide resolved
src/confcom/setup.py Outdated Show resolved Hide resolved
Copy link
Owner

@SethHollandsworth SethHollandsworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hgarvison hgarvison merged commit aff3a33 into main Apr 27, 2023
@hgarvison hgarvison deleted the feature/security_context branch April 27, 2023 15:20
SethHollandsworth added a commit that referenced this pull request May 16, 2023
…python (Azure#6144)

* changing version number naming scheme and bugfix for 32bit python

* addressing PR comments

* moving where pulling files happens from

* making a sha256 hash of the security policy print out when injecting into arm template

* taking out the --json option

* removing unused function

* adding warnings for save to file and debug mode. fixed bug with numbers for template parameters

* taking out unused function and fixing style checks

* adding error checking back in for when dmverity-vhd returns nothing

* making it so you can disable allow_elevated via the privileged field in the arm template

* Feature/security context (#18)

* securityContext

---------

Co-authored-by: Seth Hollandsworth <seth.hollandsworth@gmail.com>
Co-authored-by: Seth Hollandsworth <sethho@microsoft.com>

* changing default value of no_new_privileges

* updating tests

* taking allow_elevated out of expected fields in ARM template

* adding docs for dmverity hashing and fixing markdown styling

---------

Co-authored-by: Heather Garvison <hgarvison@microsoft.com>
SethHollandsworth pushed a commit that referenced this pull request Aug 14, 2024
* fix: --title --kind --custom-property parameters (#1)

* feat: support yaml file in register command (#3)

* fix: workspace parameter should not be required (#2)

* style: fix lint issues (#6)

* chore: update codeowner for apic-extension (#5)

* feat: revert changes to min cli version (#4)

* feat: resolve comments to CLI experience (#10)

* feat: mark "apic api register" command as preview (#13)

* feat: remove --terms-of-service parameter (#12)

* feat: remove --workspace-name parameter (#11)

* feat: support python 3.8 and 3.9 (#14)

* feat: fix command descriptions (#17)

* tests: add test cases for 'apic service' commands (#16)

* feat: Use 03-01 spec from azure-rest-api-specs repo to regenerate CLI (#19)

* fix: CLI errors (#20)

* fix: import error when run CLI command

* fix: no workspace name error when run import specification command

* feat: mark some parameters as required (#21)

* feat: mark --assignments parameter required for metadata commands

* doc: update sample commands

* feat: mark --source-resource-ids parameter as required for import-from-apim command

* doc: update description for import-from-apim command

* feat: bump version to 1.0.0b5 and update changelog (#18)

* build: fix ci (#22)

* style: fix style warnings

* test:fix test cases

* fix: service update command failure (#28)

* doc: fix command samples (#30)

* doc: update changelog per feedback (#29)

* doc: remove extra spaces in register command help message (#34)

* doc: update api definition and metadata command samples (#36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants